Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CON-603 Multiple session issue with wallet connect #15

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

Deligrim
Copy link
Member

Description:

This PR adds control of the last connected tab to the relay to ensure that the response returns to the initiating tab when requested. The approach is to store the wallet connect instance ID (unique per tab) in storage and restart the relay client transport if necessary with minimal impact on application state.

Related issue(s):

Fixes hashgraph#387

Notes for reviewer:

Checklist

  • Documented (Code comments)
  • Tested (unit, integration, etc.)

Copy link

linear bot commented Jan 10, 2025

Copy link
Member

@tmctl tmctl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me, will submit upstream for further review

@tmctl tmctl merged commit e2967f4 into main Jan 14, 2025
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session breaks with multiple tabs open
2 participants