Hedera <> WalletConnect #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler McDonald <[email protected]>
Signed-off-by: Tyler McDonald <[email protected]>
…ssions Signed-off-by: Tyler McDonald <[email protected]>
Signed-off-by: Tyler McDonald <[email protected]>
Signed-off-by: Tyler McDonald <[email protected]>
Signed-off-by: Tyler McDonald <[email protected]>
nathanklick
requested changes
Jan 19, 2024
nathanklick
requested changes
Jan 19, 2024
Signed-off-by: Tyler McDonald <[email protected]>
Co-authored-by: Nathan Klick <[email protected]> Signed-off-by: Tyler <[email protected]>
Co-authored-by: Nathan Klick <[email protected]> Signed-off-by: Tyler <[email protected]>
Co-authored-by: Nathan Klick <[email protected]> Signed-off-by: Tyler <[email protected]>
Co-authored-by: Nathan Klick <[email protected]> Signed-off-by: Tyler <[email protected]>
|
thanks @nathanklick, all code changes have been applied |
nathanklick
requested changes
Jan 22, 2024
There was a problem hiding this comment.
@hgraphql thanks the previous changes look good. One more small request regarding the deleted dependabot.yml file below.
Signed-off-by: Tyler McDonald <[email protected]>
Signed-off-by: Tyler McDonald <[email protected]>
Signed-off-by: Tyler McDonald <[email protected]>
Signed-off-by: Tyler McDonald <[email protected]>
nathanklick
approved these changes
Jan 23, 2024
nathanklick
requested changes
Jan 23, 2024
There was a problem hiding this comment.
@hgraphql Some additional changes to provide a better experience for non-forked PRs.
Co-authored-by: Nathan Klick <[email protected]> Signed-off-by: Tyler <[email protected]>
Co-authored-by: Nathan Klick <[email protected]> Signed-off-by: Tyler <[email protected]>
Co-authored-by: Nathan Klick <[email protected]> Signed-off-by: Tyler <[email protected]>
nathanklick
approved these changes
Jan 23, 2024
@nathanklick awesome, thanks for the help! |
|
@gregscullard @Ashe-Oro All my concerns are resolved. Please review and merge when you are ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference implementation
This PR intends to serve as the reference implementation of https://specs.walletconnect.com/2.0/blockchain-rpc/hedera-rpc