Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): Bump @types/react-dom from 18.3.1 to 19.0.3 #406

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 13, 2025

Bumps @types/react-dom from 18.3.1 to 19.0.3.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner January 13, 2025 00:21
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jan 13, 2025
@dependabot dependabot bot requested review from a team as code owners January 13, 2025 00:21
@dependabot dependabot bot requested review from rbarkerSL and sergmetelin January 13, 2025 00:21
@dependabot dependabot bot requested review from dalvizu and nadineloepfe January 13, 2025 00:21
Copy link

github-actions bot commented Jan 13, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.65% 523/665
🟡 Branches 64.34% 92/143
🟡 Functions 77.63% 118/152
🟡 Lines 79.94% 494/618

Test suite run success

153 tests passing in 11 suites.

Report generated by 🧪jest coverage report action from afc5c72

@andrewb1269hg
Copy link
Contributor

@dependabot rebase

Bumps [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom) from 18.3.1 to 19.0.3.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom)

---
updated-dependencies:
- dependency-name: "@types/react-dom"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/types/react-dom-19.0.3 branch from f754bd2 to afc5c72 Compare January 13, 2025 21:55
@mishomihov00
Copy link
Contributor

@hashgraph/developer-advocates This is a major version update. Please review and merge if everything is ok.

Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but we need a repo owner to review since this is a major version roll.

@tmctl
Copy link
Contributor

tmctl commented Jan 14, 2025

Looks good but we need a repo owner to review since this is a major version roll.

looks good to me, though not sure why dependabot is suggesting major version changes

@tmctl tmctl merged commit dfb424e into main Jan 14, 2025
12 checks passed
@tmctl tmctl deleted the dependabot/npm_and_yarn/types/react-dom-19.0.3 branch January 14, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants