-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deployment create
command should use the context and cluster provided for where to save the remote config
#1113
Conversation
…, to support context selection Signed-off-by: instamenta <[email protected]>
Signed-off-by: instamenta <[email protected]>
…-create-should-use-the-context-and-cluster-provided-for-where-to-save-the-remote-config-instead-of-using-the-k8s-current-context
Signed-off-by: instamenta <[email protected]>
Unit Test Results - Linux 1 files 58 suites 3s ⏱️ Results for commit b12bb81. ♻️ This comment has been updated with latest results. |
Unit Test Results - Windows 1 files 58 suites 16s ⏱️ Results for commit b12bb81. ♻️ This comment has been updated with latest results. |
E2E Test Report 16 files 121 suites 1h 22m 4s ⏱️ Results for commit b12bb81. ♻️ This comment has been updated with latest results. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1113 +/- ##
==========================================
- Coverage 83.67% 83.61% -0.07%
==========================================
Files 77 77
Lines 20634 20674 +40
Branches 1397 1322 -75
==========================================
+ Hits 17265 17286 +21
- Misses 3326 3332 +6
- Partials 43 56 +13
|
…-create-should-use-the-context-and-cluster-provided-for-where-to-save-the-remote-config-instead-of-using-the-k8s-current-context # Conflicts: # src/commands/context/tasks.ts
Description
TODO
Related Issues