Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deployment create command should use the context and cluster provided for where to save the remote config #1113

Conversation

instamenta
Copy link
Contributor

Description

TODO

Related Issues

…, to support context selection

Signed-off-by: instamenta <[email protected]>
…-create-should-use-the-context-and-cluster-provided-for-where-to-save-the-remote-config-instead-of-using-the-k8s-current-context
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Unit Test Results - Linux

  1 files   58 suites   3s ⏱️
227 tests 227 ✅ 0 💤 0 ❌
232 runs  232 ✅ 0 💤 0 ❌

Results for commit b12bb81.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Unit Test Results - Windows

  1 files   58 suites   16s ⏱️
227 tests 227 ✅ 0 💤 0 ❌
232 runs  232 ✅ 0 💤 0 ❌

Results for commit b12bb81.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

E2E Test Report

 16 files  ±0  121 suites  ±0   1h 20m 32s ⏱️ -14s
258 tests ±0  258 ✅ ±0  0 💤 ±0  0 ❌ ±0 
261 runs  ±0  261 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e6cd509. ± Comparison against base commit a3231f9.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

E2E Test Report

 16 files  121 suites   1h 22m 4s ⏱️
258 tests 258 ✅ 0 💤 0 ❌
261 runs  261 ✅ 0 💤 0 ❌

Results for commit b12bb81.

♻️ This comment has been updated with latest results.

Copy link

codacy-production bot commented Jan 7, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 3d547e41 86.67%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3d547e4) Report Missing Report Missing Report Missing
Head commit (b12bb81) 20674 17445 84.38%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1113) 15 13 86.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.61%. Comparing base (ed6527b) to head (b12bb81).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/flags.ts 88.88% 1 Missing ⚠️
src/core/config/local_config.ts 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1113      +/-   ##
==========================================
- Coverage   83.67%   83.61%   -0.07%     
==========================================
  Files          77       77              
  Lines       20634    20674      +40     
  Branches     1397     1322      -75     
==========================================
+ Hits        17265    17286      +21     
- Misses       3326     3332       +6     
- Partials       43       56      +13     
Files with missing lines Coverage Δ
src/core/helpers.ts 81.74% <ø> (-0.12%) ⬇️
src/commands/flags.ts 75.20% <88.88%> (+0.42%) ⬆️
src/core/config/local_config.ts 65.21% <83.33%> (-1.87%) ⬇️

... and 8 files with indirect coverage changes

Impacted file tree graph

…-create-should-use-the-context-and-cluster-provided-for-where-to-save-the-remote-config-instead-of-using-the-k8s-current-context

# Conflicts:
#	src/commands/context/tasks.ts
@instamenta instamenta closed this Jan 13, 2025
@instamenta instamenta deleted the 00976-solo-deployment-create-should-use-the-context-and-cluster-provided-for-where-to-save-the-remote-config-instead-of-using-the-k8s-current-context branch January 13, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant