feat: `solo deployment create` should use the context and cluster provided for where to save the remote config #1142

instamenta · 2025-01-13T11:51:50Z

Description

Addresses issue preventing passing email address via flags

Related Issues

Closes # #976

Signed-off-by: instamenta <[email protected]>

…calconfig for not prompting the user for email Signed-off-by: instamenta <[email protected]>

Signed-off-by: instamenta <[email protected]>

github-actions · 2025-01-13T12:03:55Z

Unit Test Results - Linux

1 files ±0 58 suites ±0 3s ⏱️ ±0s
227 tests ±0 227 ✅ ±0 0 💤 ±0 0 ❌ ±0
232 runs ±0 232 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 66d6a1c. ± Comparison against base commit 1cf5893.

♻️ This comment has been updated with latest results.

github-actions · 2025-01-13T12:05:43Z

Unit Test Results - Windows

1 files ±0 58 suites ±0 14s ⏱️ -1s
227 tests ±0 227 ✅ ±0 0 💤 ±0 0 ❌ ±0
232 runs ±0 232 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 66d6a1c. ± Comparison against base commit 1cf5893.

♻️ This comment has been updated with latest results.

github-actions · 2025-01-13T12:45:50Z

E2E Test Report

17 files 126 suites 1h 30m 15s ⏱️
258 tests 258 ✅ 0 💤 0 ❌
269 runs 269 ✅ 0 💤 0 ❌

Results for commit 66d6a1c.

♻️ This comment has been updated with latest results.

codacy-production · 2025-01-13T12:46:05Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for `1cf5893`¹	✅ 96.18%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`1cf5893`)	Report Missing	Report Missing	Report Missing
Head commit (`66d6a1c`)	21188	17754	83.79%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#1142)	131	126	96.18%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

codecov · 2025-01-13T12:47:05Z

Codecov Report

Attention: Patch coverage is 96.18321% with 5 lines in your changes missing coverage. Please review.

Project coverage is 83.03%. Comparing base (9bc6fcd) to head (66d6a1c).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
src/core/config/local_config.ts	0.00%	3 Missing ⚠️
src/commands/cluster/handlers.ts	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1142      +/-   ##
==========================================
- Coverage   83.37%   83.03%   -0.34%     
==========================================
  Files          77       77              
  Lines       20809    21188     +379     
  Branches     1717     1269     -448     
==========================================
+ Hits        17349    17593     +244     
- Misses       3363     3590     +227     
+ Partials       97        5      -92

Files with missing lines	Coverage Δ
src/commands/cluster/configs.ts	`84.55% <100.00%> (+1.35%)`	⬆️
src/commands/cluster/tasks.ts	`87.11% <100.00%> (+0.64%)`	⬆️
src/commands/cluster/handlers.ts	`85.13% <0.00%> (ø)`
src/core/config/local_config.ts	`67.07% <0.00%> (ø)`

... and 25 files with indirect coverage changes

test/unit/commands/cluster.test.ts

jeromy-cannon

❯ rm -Rf ~/.solo
❯ kind create cluster -n solo-e2e
Creating cluster "solo-e2e" ...
 ✓ Ensuring node image (kindest/node:v1.27.3) 🖼
 ✓ Preparing nodes 📦  
 ✓ Writing configuration 📜 
 ✓ Starting control-plane 🕹️ 
 ✓ Installing CNI 🔌 
 ✓ Installing StorageClass 💾 
Set kubectl context to "kind-solo-e2e"
You can now use your cluster with:

kubectl cluster-info --context kind-solo-e2e

Have a question, bug, or feature request? Let us know! https://kind.sigs.k8s.io/#community 🙂
❯ kind create cluster -n solo
Creating cluster "solo" ...
 ✓ Ensuring node image (kindest/node:v1.27.3) 🖼
 ✓ Preparing nodes 📦  
 ✓ Writing configuration 📜 
 ✓ Starting control-plane 🕹️ 
 ✓ Installing CNI 🔌 
 ✓ Installing StorageClass 💾 
Set kubectl context to "kind-solo"
You can now use your cluster with:

kubectl cluster-info --context kind-solo

Have a nice day! 👋
❯ git status
On branch 00976-solo-deployment-create-should-use-the-context
Your branch is up to date with 'origin/00976-solo-deployment-create-should-use-the-context'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        examples/address-book/

nothing added to commit but untracked files present (use "git add" to track)
❯ git pull
Already up to date.
❯ npm run build

> @hashgraph/[email protected] build
> rm -Rf dist && tsc && node resources/post-build-script.js

❯ npm run solo -- deployment create -n jeromy-solo --deployment-clusters kind-solo-e2e  --context-cluster kind-solo-e2e=kind-solo-e2e

> @hashgraph/[email protected] solo
> node --no-deprecation --no-warnings dist/solo.js deployment create -n jeromy-solo --deployment-clusters kind-solo-e2e --context-cluster kind-solo-e2e=kind-solo-e2e


******************************* Solo *********************************************
Version                 : 0.32.0
Kubernetes Context      : kind-solo
Kubernetes Cluster      : kind-solo
Kubernetes Namespace    : jeromy-solo
**********************************************************************************
✔ Initialize
  ✔ Acquire lease - lease acquired successfully, attempt: 1/10
⠴ Prompt local configuration
◼ Validate cluster connections
◼ Create remote config
◼ Read local configuration settings
◼ Update local configuration

? Select kubectl context to be associated with cluster: kind-solo-e2e … 
❯ docker
  docker-desktop
  gke-alex
  gke-edge
  gke-fullstack
  gke-jeromy
  gke-secure
  re-lat
  kind-solo-e2e
  kind-solo

It is prompting me for the cluster, even though I supplied the flag with the same information.

Then when I select it, I get this error:

******************************* Solo *********************************************
Version                 : 0.32.0
Kubernetes Context      : kind-solo
Kubernetes Cluster      : kind-solo
Kubernetes Namespace    : jeromy-solo
**********************************************************************************
✔ Initialize
  ✔ Acquire lease - lease acquired successfully, attempt: 1/10
✖ ENOENT: no such file or directory, open '/Users/user/.solo/cache/local-config.yaml'
◼ Validate cluster connections
◼ Create remote config
◼ Read local configuration settings
◼ Update local configuration
*********************************** ERROR *****************************************
Error installing chart solo-deployment
***********************************************************************************

I think Ivo moved the init method that creates the directories into the basecommand, you just need to call it at the beginning of the deployment command. this is because I did rm -Rf on the ~/.solo directory.

if I run solo init and then run the command again, I now get a different error:

❯ npm run solo -- init

> @hashgraph/[email protected] solo
> node --no-deprecation --no-warnings dist/solo.js init


******************************* Solo *********************************************
Version                 : 0.32.0
Kubernetes Context      : kind-solo
Kubernetes Cluster      : kind-solo
**********************************************************************************
✔ Setup home directory and cache
✔ Check dependencies [11s]
  ✔ Check dependency: helm [OS: darwin, Release: 23.6.0, Arch: arm64] [11s]
✔ Setup chart manager [1s]
✔ Copy templates in '/Users/user/.solo/cache'


***************************************************************************************
Note: solo stores various artifacts (config, logs, keys etc.) in its home directory: /Users/user/.solo
If a full reset is needed, delete the directory or relevant sub-directories before running 'solo init'.
***************************************************************************************
❯ npm run solo -- deployment create -n jeromy-solo --deployment-clusters kind-solo-e2e  --context-cluster kind-solo-e2e=kind-solo-e2e

> @hashgraph/[email protected] solo
> node --no-deprecation --no-warnings dist/solo.js deployment create -n jeromy-solo --deployment-clusters kind-solo-e2e --context-cluster kind-solo-e2e=kind-solo-e2e


******************************* Solo *********************************************
Version                 : 0.32.0
Kubernetes Context      : kind-solo
Kubernetes Cluster      : kind-solo
Kubernetes Namespace    : jeromy-solo
**********************************************************************************
✔ Initialize
  ✔ Acquire lease - lease acquired successfully, attempt: 1/10
✔ Prompt local configuration [7s]
✔ Validate cluster connections
  ✔ Testing connection to cluster: kind-solo-e2e
✖ Failed to read remote config from cluster
◼ Read local configuration settings
◼ Update local configuration
*********************************** ERROR *****************************************
failed to read existing leases, unexpected server response of '500' received
***********************************************************************************

@instamenta , this is still happening after I pulled your latest.

…-create-should-use-the-context

as requested Signed-off-by: instamenta <[email protected]>

instamenta added 2 commits January 13, 2025 11:30

added types and the tasks for selecting context to DeploymentCommand

458ddff

Signed-off-by: instamenta <[email protected]>

add tasks to the 'deployment create' command, and fix logic around lo…

16fee5d

…calconfig for not prompting the user for email Signed-off-by: instamenta <[email protected]>

instamenta requested a review from jeromy-cannon January 13, 2025 11:51

instamenta self-assigned this Jan 13, 2025

instamenta requested review from leninmehedy and a team as code owners January 13, 2025 11:51

instamenta linked an issue Jan 13, 2025 that may be closed by this pull request

solo deployment create should use the context and cluster provided for where to save the remote config instead of using the k8s current context #976

Open

fixed linter error and circular dependency

3e33c49

Signed-off-by: instamenta <[email protected]>

jeromy-cannon reviewed Jan 13, 2025

View reviewed changes

test/unit/commands/cluster.test.ts Outdated Show resolved Hide resolved

jeromy-cannon requested changes Jan 13, 2025

View reviewed changes

instamenta added 2 commits January 14, 2025 10:27

Merge remote-tracking branch 'origin/main' into 00976-solo-deployment…

a651b14

…-create-should-use-the-context

remove unusued import, and switched @ts-ignore tags for @ts-expect-error

66d6a1c

as requested Signed-off-by: instamenta <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: `solo deployment create` should use the context and cluster provided for where to save the remote config #1142

feat: `solo deployment create` should use the context and cluster provided for where to save the remote config #1142

instamenta commented Jan 13, 2025

github-actions bot commented Jan 13, 2025 •

edited

Loading

github-actions bot commented Jan 13, 2025 •

edited

Loading

github-actions bot commented Jan 13, 2025 •

edited

Loading

codacy-production bot commented Jan 13, 2025 •

edited

Loading

codecov bot commented Jan 13, 2025 •

edited

Loading

jeromy-cannon left a comment •

edited

Loading

feat: solo deployment create should use the context and cluster provided for where to save the remote config #1142

Are you sure you want to change the base?

feat: solo deployment create should use the context and cluster provided for where to save the remote config #1142

Conversation

instamenta commented Jan 13, 2025

Description

Related Issues

github-actions bot commented Jan 13, 2025 • edited Loading

Unit Test Results - Linux

github-actions bot commented Jan 13, 2025 • edited Loading

Unit Test Results - Windows

github-actions bot commented Jan 13, 2025 • edited Loading

E2E Test Report

codacy-production bot commented Jan 13, 2025 • edited Loading

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Footnotes

codecov bot commented Jan 13, 2025 • edited Loading

Codecov Report

jeromy-cannon left a comment • edited Loading

Choose a reason for hiding this comment

feat: `solo deployment create` should use the context and cluster provided for where to save the remote config #1142

feat: `solo deployment create` should use the context and cluster provided for where to save the remote config #1142

github-actions bot commented Jan 13, 2025 •

edited

Loading

github-actions bot commented Jan 13, 2025 •

edited

Loading

github-actions bot commented Jan 13, 2025 •

edited

Loading

codacy-production bot commented Jan 13, 2025 •

edited

Loading

codecov bot commented Jan 13, 2025 •

edited

Loading

jeromy-cannon left a comment •

edited

Loading