Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: account init before relay deployment #1154

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

JeffreyDallas
Copy link
Contributor

@JeffreyDallas JeffreyDallas commented Jan 14, 2025

Description

This pull request changes the following:

  • Add test matrix to default smoke test
  • Run "account init" after network deployment and node start , but before mirror & relay deployment
  • Use generated account id and private key as parameters for relay node deployment

Related Issues

JeffreyDallas and others added 14 commits January 10, 2025 13:53
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
…portforward-quit-task

Signed-off-by: Jeffrey Tang <[email protected]>

# Conflicts:
#	Taskfile.helper.yml
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas JeffreyDallas requested review from a team as code owners January 14, 2025 05:34
@JeffreyDallas JeffreyDallas self-assigned this Jan 14, 2025
Copy link
Contributor

github-actions bot commented Jan 14, 2025

Unit Test Results - Linux

  1 files  ±0   58 suites  ±0   2s ⏱️ -1s
227 tests ±0  227 ✅ ±0  0 💤 ±0  0 ❌ ±0 
232 runs  ±0  232 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e150d38. ± Comparison against base commit d662d3f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 14, 2025

Unit Test Results - Windows

  1 files  ±0   58 suites  ±0   15s ⏱️ +2s
227 tests ±0  227 ✅ ±0  0 💤 ±0  0 ❌ ±0 
232 runs  ±0  232 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e150d38. ± Comparison against base commit d662d3f.

♻️ This comment has been updated with latest results.

@JeffreyDallas JeffreyDallas changed the title 01149 d account init before relay chore: account init before relay deployment Jan 14, 2025
Copy link
Contributor

E2E Test Report

 16 files  ±0  121 suites  ±0   1h 21m 53s ⏱️ -14s
258 tests ±0  258 ✅ ±0  0 💤 ±0  0 ❌ ±0 
261 runs  ±0  261 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 86b4f76. ± Comparison against base commit 9dd76c4.

Copy link
Contributor

github-actions bot commented Jan 14, 2025

E2E Test Report

 17 files  ±0  126 suites  ±0   1h 27m 33s ⏱️ +14s
258 tests ±0  258 ✅ ±0  0 💤 ±0  0 ❌ ±0 
269 runs  ±0  269 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e150d38. ± Comparison against base commit d662d3f.

♻️ This comment has been updated with latest results.

Copy link

codacy-production bot commented Jan 14, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 79.17%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d662d3f) 21144 17708 83.75%
Head commit (e150d38) 21192 (+48) 17749 (+41) 83.75% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1154) 24 19 79.17%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 70.83333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.97%. Comparing base (d662d3f) to head (e150d38).

Files with missing lines Patch % Lines
src/commands/mirror_node.ts 75.00% 4 Missing ⚠️
src/commands/relay.ts 62.50% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1154      +/-   ##
==========================================
- Coverage   83.00%   82.97%   -0.04%     
==========================================
  Files          77       77              
  Lines       21171    21192      +21     
  Branches     1498     1509      +11     
==========================================
+ Hits        17573    17584      +11     
+ Misses       3539     3530       -9     
- Partials       59       78      +19     
Files with missing lines Coverage Δ
src/commands/relay.ts 81.41% <62.50%> (-0.61%) ⬇️
src/commands/mirror_node.ts 71.07% <75.00%> (+0.04%) ⬆️

... and 7 files with indirect coverage changes

Impacted file tree graph

mishomihov00
mishomihov00 previously approved these changes Jan 14, 2025
Copy link
Contributor

@mishomihov00 mishomihov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review applies to .github/workflows/flow-task-test.yaml

Copy link
Contributor

@jeromy-cannon jeromy-cannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like mirror node and relay to do a lookup to see if a secret exists for the default operator id's key. if it exists, then use that instead of the genesis key. I would like to see that both mirror node and json rpc relay can be deployed after an account init has been ran, without manually fetching the keys, but instead it is automated.

NOTE: the pinger is what seems to be using the operator ID/key in mirror-node, our test don't seem to verify that the pinger is working correctly.

@JeffreyDallas

Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas JeffreyDallas requested review from leninmehedy and a team as code owners January 14, 2025 23:05
Base automatically changed from 01115-D-portforward-quit-task to main January 14, 2025 23:06
@JeffreyDallas JeffreyDallas dismissed mishomihov00’s stale review January 14, 2025 23:06

The base branch was changed.

Signed-off-by: Jeffrey Tang <[email protected]>

# Conflicts:
#	.github/workflows/script/solo_smoke_test.sh
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ensure that mirror node and json rpc relay deploys correctly when account init is ran after node start
3 participants