-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: account init before relay deployment #1154
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
…portforward-quit-task Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # Taskfile.helper.yml
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1154 +/- ##
==========================================
- Coverage 83.00% 82.97% -0.04%
==========================================
Files 77 77
Lines 21171 21192 +21
Branches 1498 1509 +11
==========================================
+ Hits 17573 17584 +11
+ Misses 3539 3530 -9
- Partials 59 78 +19
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review applies to .github/workflows/flow-task-test.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like mirror node and relay to do a lookup to see if a secret exists for the default operator id's key. if it exists, then use that instead of the genesis key. I would like to see that both mirror node and json rpc relay can be deployed after an account init has been ran, without manually fetching the keys, but instead it is automated.
NOTE: the pinger is what seems to be using the operator ID/key in mirror-node, our test don't seem to verify that the pinger is working correctly.
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
The base branch was changed.
…account-init-before-relay
Signed-off-by: Jeffrey Tang <[email protected]> # Conflicts: # .github/workflows/script/solo_smoke_test.sh
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Description
This pull request changes the following:
Related Issues