Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: solo network destroy should update remote-config #1155

Merged

Conversation

instamenta
Copy link
Contributor

@instamenta instamenta commented Jan 14, 2025

Description

When network destroy is called and the namespace will be emptied but not deleted, remote config's components data will be emptied.

Related Issues

…space is not being deleted during

Signed-off-by: instamenta <[email protected]>
@instamenta instamenta self-assigned this Jan 14, 2025
@instamenta instamenta requested review from leninmehedy and a team as code owners January 14, 2025 08:04
@instamenta instamenta linked an issue Jan 14, 2025 that may be closed by this pull request
@instamenta instamenta marked this pull request as draft January 14, 2025 08:04
Copy link
Contributor

Unit Test Results - Linux

  1 files  ±0   58 suites  ±0   5s ⏱️ +2s
227 tests ±0  227 ✅ ±0  0 💤 ±0  0 ❌ ±0 
232 runs  ±0  232 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0f2eba3. ± Comparison against base commit 1cf5893.

Copy link
Contributor

Unit Test Results - Windows

  1 files  ±0   58 suites  ±0   14s ⏱️ -1s
227 tests ±0  227 ✅ ±0  0 💤 ±0  0 ❌ ±0 
232 runs  ±0  232 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0f2eba3. ± Comparison against base commit 1cf5893.

@instamenta instamenta changed the title feat: add new method to remote config delete components and call it if name… feat: solo network destroy should update remote-config Jan 14, 2025
@instamenta instamenta marked this pull request as ready for review January 14, 2025 08:19
Copy link
Contributor

E2E Test Report

 17 files  126 suites   1h 28m 33s ⏱️
258 tests 258 ✅ 0 💤 0 ❌
269 runs  269 ✅ 0 💤 0 ❌

Results for commit 0f2eba3.

1 similar comment
Copy link
Contributor

E2E Test Report

 17 files  126 suites   1h 28m 33s ⏱️
258 tests 258 ✅ 0 💤 0 ❌
269 runs  269 ✅ 0 💤 0 ❌

Results for commit 0f2eba3.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 1cf58931 42.11%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1cf5893) Report Missing Report Missing Report Missing
Head commit (0f2eba3) 21171 17730 83.75%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1155) 19 8 42.11%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 42.10526% with 11 lines in your changes missing coverage. Please review.

Project coverage is 82.98%. Comparing base (9bc6fcd) to head (0f2eba3).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/network.ts 45.45% 6 Missing ⚠️
src/core/config/remote/remote_config_manager.ts 42.85% 4 Missing ⚠️
src/core/config/local_config.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1155      +/-   ##
==========================================
- Coverage   83.37%   82.98%   -0.40%     
==========================================
  Files          77       77              
  Lines       20809    21171     +362     
  Branches     1717     1771      +54     
==========================================
+ Hits        17349    17568     +219     
- Misses       3363     3496     +133     
- Partials       97      107      +10     
Files with missing lines Coverage Δ
src/core/config/local_config.ts 67.07% <0.00%> (ø)
src/core/config/remote/remote_config_manager.ts 80.38% <42.85%> (-0.87%) ⬇️
src/commands/network.ts 65.86% <45.45%> (-0.27%) ⬇️

... and 20 files with indirect coverage changes

Impacted file tree graph

@jeromy-cannon jeromy-cannon merged commit 98b028f into main Jan 14, 2025
41 of 43 checks passed
@jeromy-cannon jeromy-cannon deleted the 00965-solo-network-destroy-should-update-remote-config branch January 14, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

solo network destroy should update remote-config
2 participants