-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: solo network destroy should update remote-config #1155
feat: solo network destroy should update remote-config #1155
Conversation
…space is not being deleted during Signed-off-by: instamenta <[email protected]>
E2E Test Report 17 files 126 suites 1h 28m 33s ⏱️ Results for commit 0f2eba3. |
1 similar comment
E2E Test Report 17 files 126 suites 1h 28m 33s ⏱️ Results for commit 0f2eba3. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1155 +/- ##
==========================================
- Coverage 83.37% 82.98% -0.40%
==========================================
Files 77 77
Lines 20809 21171 +362
Branches 1717 1771 +54
==========================================
+ Hits 17349 17568 +219
- Misses 3363 3496 +133
- Partials 97 107 +10
|
Description
When
network destroy
is called and the namespace will be emptied but not deleted, remote config's components data will be emptied.Related Issues