Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: for v0.59.x or greater set the internal IP address to 127.0.0.1 to avoid an ISS, in config.txt #1162

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

instamenta
Copy link
Contributor

Description

if the Hedera platform version satisfied 0.59.x or is greater set the internal IP address to 127.0.0.1 in config.txt
else use the existing logic

Related Issues

Signed-off-by: instamenta <[email protected]>
Copy link
Contributor

github-actions bot commented Jan 14, 2025

Unit Test Results - Linux

  1 files  ±0   58 suites  ±0   3s ⏱️ ±0s
227 tests ±0  227 ✅ ±0  0 💤 ±0  0 ❌ ±0 
232 runs  ±0  232 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit feedce7. ± Comparison against base commit 1cf5893.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 14, 2025

Unit Test Results - Windows

  1 files  ±0   58 suites  ±0   12s ⏱️ -1s
227 tests ±0  227 ✅ ±0  0 💤 ±0  0 ❌ ±0 
232 runs  ±0  232 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit feedce7. ± Comparison against base commit 1cf5893.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 14, 2025

E2E Test Report

 17 files  126 suites   1h 28m 1s ⏱️
258 tests 258 ✅ 0 💤 0 ❌
269 runs  269 ✅ 0 💤 0 ❌

Results for commit 4301669.

♻️ This comment has been updated with latest results.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 1cf58931 75.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1cf5893) Report Missing Report Missing Report Missing
Head commit (4301669) 21182 17741 83.76%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1162) 28 21 75.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.99%. Comparing base (9bc6fcd) to head (4301669).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/core/profile_manager.ts 75.00% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1162      +/-   ##
==========================================
- Coverage   83.37%   82.99%   -0.38%     
==========================================
  Files          77       77              
  Lines       20809    21182     +373     
  Branches     1717     1350     -367     
==========================================
+ Hits        17349    17580     +231     
- Misses       3363     3577     +214     
+ Partials       97       25      -72     
Files with missing lines Coverage Δ
src/core/profile_manager.ts 95.97% <75.00%> (-1.16%) ⬇️

... and 29 files with indirect coverage changes

Impacted file tree graph

@instamenta instamenta requested a review from a team as a code owner January 14, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

for v0.59.x we need to set the internal IP address to 127.0.0.1 to avoid an ISS, in config.txt
1 participant