Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Node 20 #25

Merged
merged 2 commits into from
Jan 27, 2024
Merged

Upgrade to Node 20 #25

merged 2 commits into from
Jan 27, 2024

Conversation

bradsherman
Copy link
Collaborator

@bradsherman
Fix Build
3c14363 
I ran `npm install` with the following versions and received an error.

  npm: 9.6.7
  node: v20.3.1

The error is explained in
[this](https://stackoverflow.com/questions/69692842/error-message-error0308010cdigital-envelope-routinesunsupported)
stack overflow post and is related to upgrading past node v16. I ran
`npm audit fix --force` which didn't actually fix the issue, but then I
upgrade the version of `@vercel/ncc` and the build worked after that.

I decided to upgrade all the dependencies as well since I updated one.
@bradsherman bradsherman marked this pull request as ready for review January 26, 2024 22:18
cdepillabout
cdepillabout approved these changes Jan 27, 2024
View reviewed changes
Copy link
Collaborator

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this LGTM!

@cdepillabout cdepillabout merged commit 2921343 into haskell-actions:master Jan 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bradsherman @cdepillabout