-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💄 Remove auth.google api_url #432
Conversation
WalkthroughThe changes in the pull request focus on the configuration file Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@coderabbitai The Summary is incorrect |
@sinclairpaul Thank you for letting me know that the summary is incorrect. I will regenerate the AI-generated summary to reflect the accurate changes in the PR. ✅ Actions performedSummary regeneration triggered. |
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! nice, thanks, @sinclairpaul 👍
../Frenck
Proposed Changes
The checks within recent versions of Grafana appear to look at the ini file to see if the api_url under the auth.google section exists, if it does it generates a rather annoying log message.
Removing the entry resolves this, as config is set via Environment Variables and that this is only used for SSO from Google, I would suggest the impact is low.
Related Issues
#427
Summary by CodeRabbit
New Features
Updates
These changes enhance security and user management while providing additional configuration options for Grafana.