Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve CLI configuration troubleshooting after updated #35

Merged
merged 8 commits into from
Dec 2, 2024

Conversation

hgiasac
Copy link
Collaborator

@hgiasac hgiasac commented Dec 1, 2024

Check if environment variables are set and print instructions to developers. For example:

WARNING:

  * Headers forwarding should be enabled for the following authentication schemes: [cookie openIdConnect]
    See https://github.com/hasura/ndc-http/blob/main/docs/authentication.md#headers-forwarding for more information.

Environment Variables:
  Make sure that the following environment variables were added to your subgraph configuration:

  --- ./connector/docker.yaml
  services:
    app_myapi:
      environment:
        PET_STORE_API_KEY: $APP_MYAPI_PET_STORE_API_KEY
        # ...
  ---

  --- ./connector/connector.yaml
  envMapping:
    PET_STORE_API_KEY
      fromEnv: APP_MYAPI_PET_STORE_API_KEY
    PET_STORE_URL
      fromEnv: APP_MYAPI_PET_STORE_URL
    # ...
  ---

  --- .env
  APP_MYAPI_PET_STORE_API_KEY=
  APP_MYAPI_PET_STORE_URL=
  # ...
  ---

Copy link

github-actions bot commented Dec 1, 2024

Code Coverage

Package Line Rate Health
github.com/hasura/ndc-http/connector 49%
github.com/hasura/ndc-http/connector/internal 56%
github.com/hasura/ndc-http/connector/internal/contenttype 64%
github.com/hasura/ndc-http/connector/internal/security 55%
github.com/hasura/ndc-http/ndc-http-schema/configuration 38%
github.com/hasura/ndc-http/ndc-http-schema/openapi/internal 50%
github.com/hasura/ndc-http/ndc-http-schema/openapi 40%
github.com/hasura/ndc-http/ndc-http-schema/schema 32%
github.com/hasura/ndc-http/ndc-http-schema/utils 44%
Summary 49% (3785 / 7730)

Minimum allowed line rate is 40%

@hgiasac hgiasac marked this pull request as ready for review December 2, 2024 03:43
@hgiasac hgiasac merged commit f3595d0 into main Dec 2, 2024
4 checks passed
@hgiasac hgiasac deleted the cli/generate-help branch December 2, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant