Provides support for installing on vanilla kubernetes #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadayosi
requested changes
Jan 15, 2024
|
You can also format test code separately from the issue. |
phantomjinx
force-pushed
the
k8-support
branch
from
b53b911 to
38a95e2
Compare
3 tasks
|
Checks will fail until #101 has been merged. |
phantomjinx
force-pushed
the
k8-support
branch
2 times, most recently
from
489411d to
3ca2f87
Compare
…wtio#100 * APICapabilities determines cluster version and existence of certain APIs, eg. Routes. From this determination, it concludes whether the cluster is OpenShift4 compatible * Allows a clear determination as to whether this is an OpenShift cluster or vanilla Kubernetes. This can be used to make choices on what to install, eg. Route or Ingress * Have the cluster capabilities evaluated on initialising of the operator
…hawtio#100 * Only evaluate the Route API if it is present in the cluster.
* hawtio_controller.go * Rather than adding to the extensive list of function parameters, roll them up into a single struct that can be populated then passed around instead * deployment.go * Pass in the capabilities.ApiSpec that wraps up both the IsOpenShift and version properties
* The function generateCertificateSecret can be used for both OpenShift CA signing and self-signing certificates. Just a case of determining what is used as both the caCertificate and caPrivateKey (self-signing uses the generated certificate and private key) * Rather than using the same function with the caSecret as nil, makes it obvious which to use by providing front functions that describe which sort of certificate secret will be created install-operator.sh
* Removes all of setup, operator and app resources
* Chooses between route (openshift-only) and ingress API types * Installs self-signed certificate for kubernetes installs for the hawtio-online-serving secret * Only reconcile an OAuth client if on OpenShift for now * Ensures the HAWTIO_ONLINE_AUTH envvar is always populated to specify the authentication type rather than relying on the fallback in the actual hawtio-online image config.sh script * Differentiate between openshift and k8 code by putting in different files and packages if possible
…atus hawtio#100 * While the extraction of the route url is quite straightforward, the use of ingress path rules and no hosts makes the return of a single string quite difficult. This may well need work in the future to improve the value returned
phantomjinx
force-pushed
the
k8-support
branch
from
3ca2f87 to
b75b8ce
Compare
tadayosi
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api/batch/v1beta1toapi/batch/v1;gotestfmt;capabilitiesAPI for discovering the type of cluster (OpenShift or Kubernetes) based on the existence of installed APIs, also providing the Kubernetes version and/or the OpenShift release version;hawtio-online-tls-servingsecret required for k8;cranduninstallrules for Makefiles;ingressfor Kubernetes androutefor OpenShift;Should be merged / rebased after
1. #1012. #102