-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix klayout build on macos #298
Conversation
Note that I'm not sure why |
Maybe @klayoutmatthias as a clue? |
I added a symlink to |
Looks like the osx build failed with:
|
Conda seems to be adding What's even more annoying is that the environment doesn't seem to have those variables anywhere. If I modify
becomes:
|
...also, I'm not sure where it's getting https://docs.conda.io/projects/conda-build/en/latest/user-guide/environment-variables.html#env-vars |
Honestly, I have never tested pymod generation on MacOS. Mainly because MacOS is not my home turf. The installation basically is generic, but maybe it needs to be specialized for MacOS. |
I discovered that Qt ignores standard CFLAGS and CXXFLAGS and instead uses its own QMAKE_CFLAGS and QMAKE_CXXFLAGS. I also discovered that MacOS 11.0 was the first version that supported arm64, so I bumped the minimum version up to that. Note that 10.11 is the first version that supported Metal, so we would need to use that at a minimum in order to get support for klayout. Additionally, it looks like it might be possible to build osx-arm64 from osx-x86_64 as documented at https://conda-forge.org/blog/posts/2020-10-29-macos-arm64/ -- note that they also build for macos 11.0 in there. |
Filed #299 to discuss arm64 builds. |
77bb76b
to
0ab9ad9
Compare
3b53d09
to
5dc7d28
Compare
It builds and passes tests! \o/ |
Signed-off-by: Sean Cross <[email protected]>
Add support for klayout to build on macos. This involves some rather egregeous hacks to the Qt build system to work around the fact that Conda builds things using a custom Mac SDK. Signed-off-by: Sean Cross <[email protected]>
Looks like |
I'll just remove that, then... |
Merging since both jobs passes (not sure if we want to suffix the job with |
This fixes the klayout package so that it now builds properly on
osx-arm64
.