Skip to content

Commit

Permalink
Merge bitcoin-core#369: doc: Update PR template, update documentation…
Browse files Browse the repository at this point in the history
… around CI artifacts

90048be doc: update documentation around CI artifacts (jarolrod)
572343c doc: update pr template (jarolrod)

Pull request description:

  Update PR template and documentation for the move to github actions, also mentions the new need to make the macOS binary executable.

ACKs for top commit:
  pablomartin4btc:
    ACK 90048be

Tree-SHA512: a0a97ad37684be59367b49ea27e9776a961ec8cfeb7a0e323f5f6fb5d548df23b1aa3e7995645c315997db3676dedec60721b78bbfa43f319f11dca96ed7d377
  • Loading branch information
hebasto committed Nov 23, 2023
2 parents 46e93de + 90048be commit c77a96d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 13 deletions.
9 changes: 4 additions & 5 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,9 @@ patches often sit for a long time.
-->

<!--
Links for Windows and macOS build artifacts. Replace <PR> with the assigned pull request number.
Link to github actions build artifacts.
[![Build Artifacts](https://img.shields.io/badge/Build%20Artifacts-green
)]()
[![Windows](https://img.shields.io/badge/OS-Windows-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/<PR>)
[![Intel macOS](https://img.shields.io/badge/OS-Intel%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/<PR>)
[![Apple Silicon macOS](https://img.shields.io/badge/OS-Apple%20Silicon%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/<PR>)
[![ARM64 Android](https://img.shields.io/badge/OS-Android-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/<PR>)
-->
12 changes: 4 additions & 8 deletions src/qml/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,13 @@

This directory contains the source code for an experimental Bitcoin Core graphical user interface (GUI) built using the [Qt Quick](https://doc.qt.io/qt-5/qtquick-index.html) framework.

Insecure CI artifacts are available for local testing of the master branch, avoiding the need to build:
- for Windows: [`insecure_win_gui.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip)
- for Intel macOS: [`insecure_mac_gui.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip)
- for Apple Silicon macOS: [`insecure_mac_arm64_gui.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip)
- for ARM64 Android: [`insecure_android_apk.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip)
Unsecure CI artifacts are available for local testing of the master branch, avoiding the need to build. These can be found under the [Actions](https://github.com/bitcoin-core/gui-qml/actions?query=branch%3Amain) tab. It is required to have and be logged into a github account in order to download these.

Note: For Apple Silicon macOS machines, the binary must be signed before it can
be ran. To apply a signature, run the following on the unzipped CI artifact:
Note: For macOS, the CI artifact binary must be made executable and code-signed before it can
be ran. To make executable and apply a signature, run the following on the unzipped CI artifact:

```
codesign -s - ./Downloads/insecure_mac_arm64_gui
chmod +x ./Downloads/bitcoin-qt && codesign -s - ./Downloads/bitcoin-qt
```

## Goals and Limitations
Expand Down

0 comments on commit c77a96d

Please sign in to comment.