-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add global --quiet flag to hide non-error messages #656
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #656 +/- ##
==========================================
+ Coverage 45.98% 46.36% +0.38%
==========================================
Files 171 179 +8
Lines 7514 7877 +363
==========================================
+ Hits 3455 3652 +197
- Misses 3616 3765 +149
- Partials 443 460 +17 ☔ View full report in Codecov by Sentry. |
3fd7062
to
98509d9
Compare
2552b2d
to
6c84163
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you refactor all the test to use a test helper and use a list of test cases ?
Is there a chance that we fix the cyclic import by moving this to the main.go: Lines 42 to 63 in 2df5e92
And maybe move the root command somewhere closer to the base package ? Line 32 in 2df5e92
|
I think we could, but it makes most sense to me to define subcommands where the root command is defined. Also, testing in packages ending with |
In terms of logic, I understand why, though I don't think it will make it less understandable. But in terms of code structure, I'd rather have a tree/diamond shape than those cyclic imports. Happy to merge this, though. |
## [1.42.0](v1.41.1...v1.42.0) (2024-02-01) ### Features * add global --quiet flag to hide non-error messages ([#656](#656)) ([25fcbbf](25fcbbf)), closes [#644](#644) * allow adding/removing multiple labels at once ([#665](#665)) ([919c446](919c446)), closes [#662](#662) * group subcommands in command help ([#675](#675)) ([0cb271f](0cb271f)) * **server:** remove unsupported linux32 rescue type ([#679](#679)) ([5bb0350](5bb0350)) ### Bug Fixes * refetch after creating managed certificate ([#685](#685)) ([4864553](4864553)) * **server:** fix typo in ip subcommand ([#678](#678)) ([c5e3f00](c5e3f00)) * use --poll-interval flag ([#660](#660)) ([b9328a6](b9328a6))
Closes #644