Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make state mockable #659

Merged
merged 5 commits into from
Jan 4, 2024
Merged

refactor: make state mockable #659

merged 5 commits into from
Jan 4, 2024

Conversation

phm07
Copy link
Contributor

@phm07 phm07 commented Jan 3, 2024

No description provided.

@phm07 phm07 added the refactor label Jan 3, 2024
@phm07 phm07 self-assigned this Jan 3, 2024
@phm07 phm07 requested a review from a team as a code owner January 3, 2024 12:14
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 399 lines in your changes are missing coverage. Please review.

Comparison is base (f636b5e) 45.98% compared to head (6597bd5) 45.98%.

❗ Current head 6597bd5 differs from pull request most recent head f5a7833. Consider uploading reports for the commit f5a7833 to get more accurate results

Files Patch % Lines
internal/cmd/server/server.go 0.00% 35 Missing ⚠️
internal/cmd/loadbalancer/load_balancer.go 0.00% 23 Missing ⚠️
internal/cmd/network/network.go 0.00% 16 Missing ⚠️
internal/cmd/server/create.go 36.36% 10 Missing and 4 partials ⚠️
internal/cmd/firewall/firewall.go 0.00% 13 Missing ⚠️
internal/cmd/floatingip/floatingip.go 0.00% 13 Missing ⚠️
internal/cmd/primaryip/primaryip.go 0.00% 13 Missing ⚠️
internal/cmd/volume/volume.go 0.00% 13 Missing ⚠️
internal/cmd/image/image.go 0.00% 9 Missing ⚠️
internal/cmd/certificate/certificate.go 0.00% 8 Missing ⚠️
... and 95 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #659   +/-   ##
=======================================
  Coverage   45.98%   45.98%           
=======================================
  Files         171      171           
  Lines        7514     7514           
=======================================
  Hits         3455     3455           
  Misses       3616     3616           
  Partials      443      443           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

internal/state/state.go Outdated Show resolved Hide resolved
internal/state/state.go Outdated Show resolved Hide resolved
internal/cli/root.go Show resolved Hide resolved
@phm07 phm07 changed the title refactor: make root command mockable refactor: make state mockable Jan 4, 2024
internal/state/state.go Outdated Show resolved Hide resolved
internal/state/helpers.go Show resolved Hide resolved
Copy link
Member

@jooola jooola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@phm07 phm07 merged commit 72ec720 into main Jan 4, 2024
3 checks passed
@phm07 phm07 deleted the mockable-root branch January 4, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants