Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update goreleaser/goreleaser-action action to v6 #802

Merged
merged 4 commits into from
Jul 4, 2024
Merged

deps: update goreleaser/goreleaser-action action to v6 #802

merged 4 commits into from
Jul 4, 2024

Conversation

suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented Jul 3, 2024

Fixed the warning.

$ goreleaser check
  • only configurations files on  version: 2  are supported, yours is  version: 0 , please update your configuration
  • checking                                 path=.goreleaser.yml
e  • 1 configuration file(s) validated
  • thanks for using goreleaser!

https://goreleaser.com/blog/goreleaser-v2/?h=v2#upgrading

It should only warn you about the version header in the configuration file, which you can fix by adding version: 2 to it.

Test

$ goreleaser check                       
  • checking                                 path=.goreleaser.yml
  • 1 configuration file(s) validated
  • thanks for using goreleaser!

Fixed the warning.

```console
$ goreleaser check
  • only configurations files on  version: 2  are supported, yours is  version: 0 , please update your configuration
  • checking                                 path=.goreleaser.yml
e  • 1 configuration file(s) validated
  • thanks for using goreleaser!
```
@suzuki-shunsuke suzuki-shunsuke marked this pull request as ready for review July 3, 2024 21:25
@suzuki-shunsuke suzuki-shunsuke requested a review from a team as a code owner July 3, 2024 21:25
@apricote
Copy link
Member

apricote commented Jul 4, 2024

Thanks for the PR!

We are currently still using goreleaser v1 in our CI: https://github.com/hetznercloud/cli/actions/runs/9780256036/job/27029282526#step:7:13

There is a PR open to update to v2 and v6 of the action: #772. It was still missing the required changes to the configuration, like this one. If you want, you can merge the changes from #772 and apply the other migration steps in this PR :)

@jooola jooola changed the title chore(goreleaser): set version: 2 chore: set goreleaser version: 2 Jul 4, 2024
@suzuki-shunsuke
Copy link
Contributor Author

suzuki-shunsuke commented Jul 4, 2024

Oh, I see.

Warning: You are using 'latest' as default version. Will lock to '~> v1'.

I misunderstood that v2 is used because the version is latest.

version: latest

@suzuki-shunsuke
Copy link
Contributor Author

I added a commit to update goreleaser-action to v6. c02e026

@jooola jooola changed the title chore: set goreleaser version: 2 deps: update goreleaser/goreleaser-action action to v6 Jul 4, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.54%. Comparing base (701cceb) to head (08f773d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #802      +/-   ##
==========================================
- Coverage   59.75%   59.54%   -0.21%     
==========================================
  Files         210      210              
  Lines        7598     7651      +53     
==========================================
+ Hits         4540     4556      +16     
- Misses       2419     2453      +34     
- Partials      639      642       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola
Copy link
Member

jooola commented Jul 4, 2024

Awesome! Thanks for the PR.

@jooola jooola merged commit 53abf66 into hetznercloud:main Jul 4, 2024
5 checks passed
@suzuki-shunsuke suzuki-shunsuke deleted the chore-goreleaser-version-2 branch July 4, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants