fix: allow getting resources with number as name

hcloud/certificate.go

@@ -130,7 +130,10 @@ func (c *CertificateClient) GetByName(ctx context.Context, name string) (*Certif
 // retrieves a Certificate by its name. If the Certificate does not exist, nil is returned.
 func (c *CertificateClient) Get(ctx context.Context, idOrName string) (*Certificate, *Response, error) {
 	if id, err := strconv.ParseInt(idOrName, 10, 64); err == nil {
-		return c.GetByID(ctx, id)
+		cert, res, err := c.GetByID(ctx, id)
+		if cert != nil {
+			return cert, res, err
+		}
 	}
 	return c.GetByName(ctx, idOrName)
 }

hcloud/firewall.go

@@ -128,7 +128,10 @@ func (c *FirewallClient) GetByName(ctx context.Context, name string) (*Firewall,
 // retrieves a Firewall by its name. If the Firewall does not exist, nil is returned.
 func (c *FirewallClient) Get(ctx context.Context, idOrName string) (*Firewall, *Response, error) {
 	if id, err := strconv.ParseInt(idOrName, 10, 64); err == nil {
-		return c.GetByID(ctx, id)
+		fw, res, err := c.GetByID(ctx, id)
+		if fw != nil {
+			return fw, res, err
+		}
 	}
 	return c.GetByName(ctx, idOrName)
 }

hcloud/floating_ip.go

@@ -129,7 +129,10 @@ func (c *FloatingIPClient) GetByName(ctx context.Context, name string) (*Floatin
 // retrieves a Floating IP by its name. If the Floating IP does not exist, nil is returned.
 func (c *FloatingIPClient) Get(ctx context.Context, idOrName string) (*FloatingIP, *Response, error) {
 	if id, err := strconv.ParseInt(idOrName, 10, 64); err == nil {
-		return c.GetByID(ctx, id)
+		ip, res, err := c.GetByID(ctx, id)
+		if ip != nil {
+			return ip, res, err
+		}
 	}
 	return c.GetByName(ctx, idOrName)
 }

hcloud/image.go

@@ -134,7 +134,10 @@ func (c *ImageClient) GetByNameAndArchitecture(ctx context.Context, name string,
 // Deprecated: Use [ImageClient.GetForArchitecture] instead.
 func (c *ImageClient) Get(ctx context.Context, idOrName string) (*Image, *Response, error) {
 	if id, err := strconv.ParseInt(idOrName, 10, 64); err == nil {
-		return c.GetByID(ctx, id)
+		img, res, err := c.GetByID(ctx, id)
+		if img != nil {
+			return img, res, err
+		}
 	}
 	return c.GetByName(ctx, idOrName)
 }
@@ -146,7 +149,10 @@ func (c *ImageClient) Get(ctx context.Context, idOrName string) (*Image, *Respon
 // check for this in your calling method.
 func (c *ImageClient) GetForArchitecture(ctx context.Context, idOrName string, architecture Architecture) (*Image, *Response, error) {
 	if id, err := strconv.ParseInt(idOrName, 10, 64); err == nil {
-		return c.GetByID(ctx, id)
+		img, res, err := c.GetByID(ctx, id)
+		if img != nil {
+			return img, res, err
+		}
 	}
 	return c.GetByNameAndArchitecture(ctx, idOrName, architecture)
 }

hcloud/load_balancer.go

@@ -275,7 +275,10 @@ func (c *LoadBalancerClient) GetByName(ctx context.Context, name string) (*LoadB
 // retrieves a Load Balancer by its name. If the Load Balancer does not exist, nil is returned.
 func (c *LoadBalancerClient) Get(ctx context.Context, idOrName string) (*LoadBalancer, *Response, error) {
 	if id, err := strconv.ParseInt(idOrName, 10, 64); err == nil {
-		return c.GetByID(ctx, id)
+		lb, res, err := c.GetByID(ctx, id)
+		if lb != nil {
+			return lb, res, err
+		}
 	}
 	return c.GetByName(ctx, idOrName)
 }

hcloud/network.go

@@ -119,7 +119,10 @@ func (c *NetworkClient) GetByName(ctx context.Context, name string) (*Network, *
 // retrieves a network by its name. If the network does not exist, nil is returned.
 func (c *NetworkClient) Get(ctx context.Context, idOrName string) (*Network, *Response, error) {
 	if id, err := strconv.ParseInt(idOrName, 10, 64); err == nil {
-		return c.GetByID(ctx, id)
+		n, res, err := c.GetByID(ctx, id)
+		if n != nil {
+			return n, res, err
+		}
 	}
 	return c.GetByName(ctx, idOrName)
 }

hcloud/placement_group.go

@@ -70,7 +70,10 @@ func (c *PlacementGroupClient) GetByName(ctx context.Context, name string) (*Pla
 // retrieves a PlacementGroup by its name. If the PlacementGroup does not exist, nil is returned.
 func (c *PlacementGroupClient) Get(ctx context.Context, idOrName string) (*PlacementGroup, *Response, error) {
 	if id, err := strconv.ParseInt(idOrName, 10, 64); err == nil {
-		return c.GetByID(ctx, id)
+		pg, res, err := c.GetByID(ctx, id)
+		if pg != nil {
+			return pg, res, err
+		}
 	}
 	return c.GetByName(ctx, idOrName)
 }

hcloud/primary_ip.go

@@ -209,7 +209,10 @@ func (c *PrimaryIPClient) GetByName(ctx context.Context, name string) (*PrimaryI
 // retrieves a Primary IP by its name. If the Primary IP does not exist, nil is returned.
 func (c *PrimaryIPClient) Get(ctx context.Context, idOrName string) (*PrimaryIP, *Response, error) {
 	if id, err := strconv.ParseInt(idOrName, 10, 64); err == nil {
-		return c.GetByID(ctx, id)
+		ip, res, err := c.GetByID(ctx, id)
+		if ip != nil {
+			return ip, res, err
+		}
 	}
 	return c.GetByName(ctx, idOrName)
 }

hcloud/server.go

@@ -230,7 +230,10 @@ func (c *ServerClient) GetByName(ctx context.Context, name string) (*Server, *Re
 // retrieves a server by its name. If the server does not exist, nil is returned.
 func (c *ServerClient) Get(ctx context.Context, idOrName string) (*Server, *Response, error) {
 	if id, err := strconv.ParseInt(idOrName, 10, 64); err == nil {
-		return c.GetByID(ctx, id)
+		srv, res, err := c.GetByID(ctx, id)
+		if srv != nil {
+			return srv, res, err
+		}
 	}
 	return c.GetByName(ctx, idOrName)
 }

hcloud/ssh_key.go

@@ -71,7 +71,10 @@ func (c *SSHKeyClient) GetByFingerprint(ctx context.Context, fingerprint string)
 // retrieves a SSH key by its name. If the SSH key does not exist, nil is returned.
 func (c *SSHKeyClient) Get(ctx context.Context, idOrName string) (*SSHKey, *Response, error) {
 	if id, err := strconv.ParseInt(idOrName, 10, 64); err == nil {
-		return c.GetByID(ctx, id)
+		sshKey, res, err := c.GetByID(ctx, id)
+		if sshKey != nil {
+			return sshKey, res, err
+		}
 	}
 	return c.GetByName(ctx, idOrName)
 }

hcloud/volume.go

@@ -89,7 +89,10 @@ func (c *VolumeClient) GetByName(ctx context.Context, name string) (*Volume, *Re
 // retrieves a volume by its name. If the volume does not exist, nil is returned.
 func (c *VolumeClient) Get(ctx context.Context, idOrName string) (*Volume, *Response, error) {
 	if id, err := strconv.ParseInt(idOrName, 10, 64); err == nil {
-		return c.GetByID(ctx, id)
+		vol, res, err := c.GetByID(ctx, id)
+		if vol != nil {
+			return vol, res, err
+		}
 	}
 	return c.GetByName(ctx, idOrName)
 }