Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add generic API request helper functions #572

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

jooola
Copy link
Member

@jooola jooola commented Dec 20, 2024

Those helpers function will be used to replace a lot of boilerplate using in clients.

See the tests to have a better idea of how it can be used.

For now, no API clients are refactored to use those helpers, this will happen incrementally in future PRs.

@jooola jooola requested a review from a team as a code owner December 20, 2024 10:57
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 43.10345% with 33 lines in your changes missing coverage. Please review.

Project coverage is 67.58%. Comparing base (51baf8d) to head (1427945).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
hcloud/client_generic.go 43.10% 22 Missing and 11 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #572      +/-   ##
==========================================
- Coverage   67.87%   67.58%   -0.29%     
==========================================
  Files          47       48       +1     
  Lines        4912     4970      +58     
==========================================
+ Hits         3334     3359      +25     
- Misses       1170     1192      +22     
- Partials      408      419      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola jooola merged commit 6524772 into main Dec 20, 2024
6 checks passed
@jooola jooola deleted the generic_json_client branch December 20, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants