HHH-18901 Do not enhance if AccessType default is PROPERTY #9586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Scott Marlow <[email protected]>
yrodiere
reviewed
Jan 8, 2025
Comment on lines
+532
to
+534
| if ( AccessType.PROPERTY == defaultAccessType) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Not sure if you're done yet, but just in case: this will short-circuit the strategy selection below (see the switch) and skip logging. You probably want something more involved than an early return?
There was a problem hiding this comment.
Definitely will need further changes for the reason you raise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-18901
Trying change to not enhance entity classes that have accessType default of PROPERTY.