HHH-7180 Test and fix wrong collection key equality comparisons #9603
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -126,7 +126,7 @@ | |||
| Object id = getIdentifier( session, ref ); | |||
|
|
|||
| // only evict if the related entity has changed | |||
| if ( ( id != null && !id.equals( oldId ) ) || ( oldId != null && !oldId.equals( id ) ) ) { | |||
| if ( ( id != null || oldId != null ) && !collectionPersister.getKeyType().isEqual( oldId, id ) ) { | |||
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| @@ -39,7 +39,7 @@ | |||
| CollectionPersister persister, Object id, PersistentCollection<?> snapshot) { | |||
| return isCollectionSnapshotValid( snapshot ) | |||
| && persister.getRole().equals( snapshot.getRole() ) | |||
| && id.equals( snapshot.getKey() ); | |||
| && persister.getKeyType().isEqual( id, snapshot.getKey() ); | |||
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
| public void cleanup(SessionFactoryScope scope) { | ||
| scope.inTransaction( | ||
| session -> { | ||
| session.createQuery( "delete from Child" ).executeUpdate(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note test
| scope.inTransaction( | ||
| session -> { | ||
| session.createQuery( "delete from Child" ).executeUpdate(); | ||
| session.createQuery( "delete from Parent" ).executeUpdate(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note test
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-7180