Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mirror Node Web3 ChainID configuration #447

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

georgi-l95
Copy link
Contributor

Description:
This PR aims to fix the mirror node web3 chainID to 298, which is the same as the consensus node. It was previously set to 296.

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: georgi-l95 <[email protected]>
@georgi-l95 georgi-l95 added Bug An error that causes the feature to behave differently than what was expected based on design. Limechain labels Nov 21, 2023
@georgi-l95 georgi-l95 added this to the 2.16.0 milestone Nov 21, 2023
@georgi-l95 georgi-l95 self-assigned this Nov 21, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@natanasow natanasow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgi-l95 georgi-l95 merged commit 38143f4 into main Nov 22, 2023
9 checks passed
@georgi-l95 georgi-l95 deleted the fix-mirror-node-web3-chain-id branch November 22, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An error that causes the feature to behave differently than what was expected based on design. Limechain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants