Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exit when unable to transition to next state #451

Merged

Conversation

isavov
Copy link
Contributor

@isavov isavov commented Nov 27, 2023

Description:
This PR updates the StateController to exit if unable to transition to next state.

Related issue(s):

Fixes #450

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@isavov isavov added the Bug An error that causes the feature to behave differently than what was expected based on design. label Nov 27, 2023
@isavov isavov self-assigned this Nov 27, 2023
@isavov isavov linked an issue Nov 27, 2023 that may be closed by this pull request
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@georgi-l95 georgi-l95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isavov isavov merged commit d9ac855 into main Nov 27, 2023
9 checks passed
@isavov isavov deleted the 450-local-node-gets-stuck-when-unable-to-transition-to-next-state branch November 27, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug An error that causes the feature to behave differently than what was expected based on design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local node gets stuck when unable to transition to next state
2 participants