Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add additional file sharing check and update readme #859

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

natanasow
Copy link
Contributor

Description:

Related issue(s):

Fixes #821

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 62.89%. Comparing base (b5d7d50) to head (b3733e9).

Files with missing lines Patch % Lines
src/services/DockerService.ts 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #859      +/-   ##
==========================================
- Coverage   62.96%   62.89%   -0.08%     
==========================================
  Files          30       30              
  Lines        1234     1237       +3     
  Branches      149      149              
==========================================
+ Hits          777      778       +1     
- Misses        436      438       +2     
  Partials       21       21              
Files with missing lines Coverage Δ
src/constants.ts 100.00% <100.00%> (ø)
src/services/DockerService.ts 8.86% <0.00%> (-0.12%) ⬇️

Impacted file tree graph

---- 🚨 Try these New Features:

Signed-off-by: nikolay <[email protected]>
@natanasow natanasow self-assigned this Nov 20, 2024
@natanasow natanasow marked this pull request as ready for review November 20, 2024 11:35
@natanasow natanasow merged commit 2f9cc8c into main Nov 20, 2024
15 of 16 checks passed
@natanasow natanasow deleted the 821-update-readme-and-version branch November 20, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update README w latest docker version logic
4 participants