Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial coverage for Victoria 3 (Vic3) #346

Merged
merged 42 commits into from
Jun 3, 2024
Merged

Initial coverage for Victoria 3 (Vic3) #346

merged 42 commits into from
Jun 3, 2024

Conversation

hmlendea
Copy link
Owner

@hmlendea hmlendea commented May 24, 2023

WIP since 2022/11/04

@klorpa
Copy link
Contributor

klorpa commented May 25, 2023

Wouldn't it be better to link the languages to Victoria 3's cultures, rather than the country tags?

@hmlendea
Copy link
Owner Author

I would. But when I linked them, I wasn't able to find a way to dynamically change the names in the game, which is one of the reasons I never finished this.
I will, eventually, have another look and see if the game supports such functionality now, since it got quite a few patches at this point.
Currently I will continue linking them this way and then modify it later, as needed.

@hmlendea hmlendea added the vic3 Related to the Victoria 3 (vanilla) version label May 25, 2023
@hmlendea hmlendea changed the title Support for Vic3 Victoria 3 Support for Vic3 (Victoria 3) Jun 6, 2023
@hmlendea hmlendea changed the title Support for Vic3 (Victoria 3) Support for Victoria 3 (Vic3) May 27, 2024
@hmlendea hmlendea changed the title Support for Victoria 3 (Vic3) Initial coverage for Victoria 3 (Vic3) Jun 3, 2024
@hmlendea hmlendea merged commit 9e3bc1c into master Jun 3, 2024
2 checks passed
@hmlendea hmlendea deleted the vic3 branch June 3, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vic3 Related to the Victoria 3 (vanilla) version work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants