Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap Client Module #50

Merged
merged 42 commits into from
Dec 19, 2024
Merged

Bootstrap Client Module #50

merged 42 commits into from
Dec 19, 2024

Conversation

neonphog
Copy link
Collaborator

@neonphog neonphog commented Dec 10, 2024 •
edited
Loading

DEPENDS ON #58

  • Adds a bootstrap test server helper to the test_utils crate that should let us have zero config testing bootstrap servers.
  • The test_utils crate is now a dependency of the core crate if the test_utils feature is enabled. Let me know if we should do this differently.
  • Bootstrap module api written
  • Bootstrap module core implementation that can serve both for production and for testing written.
  • I only ended up with two tests... one that exercises the TestBootstrapSrv helper, and one that proves out the client retry loops by having a server that errors until we tell it not to. -- let me know if there are more tests I should write.

@neonphog neonphog changed the base branch from main to boot-srv-backend December 11, 2024 23:02
Base automatically changed from boot-srv-backend to main December 12, 2024 21:49
@neonphog neonphog changed the title wip bootstrap cli Bootstrap Client Module Dec 12, 2024
@neonphog neonphog marked this pull request as ready for review December 12, 2024 23:44
@neonphog neonphog requested a review from a team December 12, 2024 23:44
ThetaSinner
ThetaSinner reviewed Dec 16, 2024
View reviewed changes
Makefile Show resolved Hide resolved
crates/api/src/agent.rs Show resolved Hide resolved
crates/api/src/config.rs Outdated Show resolved Hide resolved
crates/bootstrap_srv/src/bin/kitsune2-bootstrap-srv.rs Outdated Show resolved Hide resolved
crates/bootstrap_srv/src/server.rs Outdated Show resolved Hide resolved
crates/core/src/factories/core_bootstrap.rs Show resolved Hide resolved
crates/core/src/factories/core_bootstrap.rs Outdated Show resolved Hide resolved
crates/core/src/factories/core_bootstrap.rs Outdated Show resolved Hide resolved
crates/core/src/factories/core_bootstrap.rs Show resolved Hide resolved
crates/core/src/factories/core_bootstrap.rs Show resolved Hide resolved
jost-s
jost-s previously approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I can't think of more tests to write either.

crates/api/src/bootstrap.rs Outdated Show resolved Hide resolved
crates/api/src/config.rs Outdated Show resolved Hide resolved
crates/core/src/factories/core_bootstrap.rs Outdated Show resolved Hide resolved
crates/core/src/factories/core_bootstrap.rs Outdated Show resolved Hide resolved
@neonphog neonphog changed the base branch from main to config-v2 December 18, 2024 18:30
Base automatically changed from config-v2 to main December 19, 2024 15:30
ThetaSinner
ThetaSinner approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@neonphog neonphog merged commit 8cf34ea into main Dec 19, 2024
5 checks passed
@neonphog neonphog deleted the bootstrap-cli branch December 19, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThetaSinner ThetaSinner ThetaSinner approved these changes

@jost-s jost-s jost-s left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neonphog @ThetaSinner @jost-s