Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signing Agent Infos #55

Merged
merged 23 commits into from
Jan 6, 2025
Merged

Signing Agent Infos #55

merged 23 commits into from
Jan 6, 2025

Conversation

neonphog
Copy link
Collaborator

@neonphog neonphog commented Dec 13, 2024 •
edited
Loading

Working on finishing off the space module. However, since this is so cross-cutting, I'm not quite there yet, and would like to get this part reviewed and merged before I make it even more unwieldy.

This PR:

  • Adds some current and target storage arc APIs to the LocalAgent type which gossip and sharding will make use of.
  • Adds hooks in the space module to sign agent infos on JOIN and sign tombstones on LEAVE.
  • Moves the peer store agent builder into test_utils crate and adds some TestLocalAgent helper structs.

Follow-on work:

  • Still need a task to check for about-to-expire local infos and sign new ones.
  • Still need to inform bootstrap/gossip/sharding modules of updates.

@neonphog neonphog changed the title wip signing agent infos Signing Agent Infos Dec 19, 2024
@neonphog neonphog marked this pull request as ready for review December 19, 2024 22:05
@neonphog neonphog requested a review from a team December 19, 2024 22:05
ThetaSinner
ThetaSinner reviewed Dec 20, 2024
View reviewed changes
Copy link
Member

@ThetaSinner ThetaSinner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots to ask and discuss, not many changes to request though

Cargo.toml Outdated Show resolved Hide resolved
crates/api/src/agent.rs Outdated Show resolved Hide resolved
crates/api/src/agent.rs Show resolved Hide resolved
crates/api/src/agent.rs Outdated Show resolved Hide resolved
crates/api/src/agent.rs Show resolved Hide resolved
crates/core/src/factories/core_space.rs Show resolved Hide resolved
crates/core/src/factories/core_space.rs Show resolved Hide resolved
crates/core/src/factories/core_space/test.rs Outdated Show resolved Hide resolved
crates/core/src/lib.rs Show resolved Hide resolved
crates/test_utils/src/agent.rs Show resolved Hide resolved
Base automatically changed from tx-integrate to main December 20, 2024 16:16
ThetaSinner
ThetaSinner previously approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! :)

jost-s
jost-s previously approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

crates/api/src/agent.rs Show resolved Hide resolved
crates/api/src/agent.rs Outdated Show resolved Hide resolved
crates/core/src/factories/mem_peer_store/test.rs Show resolved Hide resolved
crates/core/src/factories/core_fetch/test.rs Show resolved Hide resolved
crates/core/src/factories/core_space.rs Outdated Show resolved Hide resolved
@neonphog neonphog dismissed stale reviews from jost-s and ThetaSinner via e2a30a4 January 6, 2025 17:19
ThetaSinner
ThetaSinner previously approved these changes Jan 6, 2025
View reviewed changes
jost-s
jost-s previously approved these changes Jan 6, 2025
View reviewed changes
@neonphog neonphog dismissed stale reviews from jost-s and ThetaSinner via cb4e384 January 6, 2025 17:36
@neonphog neonphog merged commit 9485a26 into main Jan 6, 2025
5 checks passed
@neonphog neonphog deleted the space-mod branch January 6, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jost-s jost-s jost-s approved these changes

@ThetaSinner ThetaSinner ThetaSinner left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neonphog @ThetaSinner @jost-s