Move the in-memory op store to the core crate #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThetaSinner
force-pushed
the
move-mem-op-store-to-core
branch
from
c013b96 to
b7b5eb3
Compare
ThetaSinner
force-pushed
the
move-mem-op-store-to-core
branch
from
23d01e3 to
5962084
Compare
|
This one did conflict with the docs PR, but only on imports |
neonphog
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, remove the
kitsune2_memorymodule and move the mem op store from there tokitsune2_core. I think I've integrated it right with the builder pattern but that's probably the bit that needs the most checking :)