Update GH Workflows to have jruby. #391
Conversation
There was a problem hiding this comment.
@ParamagicDev Ah, I believe the suite is failing because JRuby is running the spec:features suite, which doesn't include the rails_helper.rb fix.
Is it possible to exclude the spec:features suite for the JRuby run only? The other reason I had removed that suite in the JRuby workflow (bundle exec rake spec:units spec:integrations) is that the end-to-end CLI tests are waaaay slower on JRuby due to the cold starts, and I don't really care if they run there.
Edit: If that's not easy to do, I'm OK with keeping the JRuby workflow separate. Also, I wonder if having it separate helps to parallelize GH Actions at all.
|
@joshuap so basically only |
KonnorRogers
force-pushed
the
patch-2
branch
from
16b2e7d to
d7939c4
Compare
|
As evidenced by my many attempts here, couldn't figure out why this wasn't working. Turns out this is broken by Bundler 2.2.10 https://mobile.twitter.com/getajobmike/status/1361372486604967940 Going to downgrade to 2.2.9 and lock the gem file until a fix lands. |
KonnorRogers
force-pushed
the
patch-2
branch
from
2bde887 to
8312b83
Compare
Update jruby.yml with ruby/setup
Add jruby to pull request actions
tests: try with jruby-head
Add java back in.
change to 9.2.13.0
chore: Remove java
downgrade to 9.2.12.0
go back up to 9.2.14.0
Update rails_helper.rb
condense jruby into one workflow
Update ruby.yml
remove rails master for jruby.
Update ruby.yml
parallelize workflows
fix syntax errors
fix syntax errors
fix key issues
rebase from main
change the way sources are defined for rails main{
rewrite sources
fighting with sources
possible source fix?
Update Appraisals
Update Appraisals
Update Appraisals
reinstall gemfiles
fix for bundler 2.2.10
fix for bundler 2.2.10
fix for bundler 2.2.10
lock bundler to 2.2.9
KonnorRogers
force-pushed
the
patch-2
branch
from
8cab5a9 to
cae41a1
Compare
|
In other news, when switching to parallelized jobs, I noticed something interesting, the entire CI would complete in just about a minute if not for Rails master. Everything else is either under 1 minute or just over a minute including Jruby!
|
|
@ParamagicDev the current run on this PR is showing rails master completing in 1m on ruby 2.7, right? I'm OK with removing rails master from the build if it's a huge improvement, but we may be approaching diminishing returns here. Does splitting out
|
|
@joshuap It appears we are hitting diminishing returns. I tried this workflow with separated jobs just to see what the time would be. Ill revert it back and check the changes. If anything we could also just split jruby into a seperate job if it takes too long when part of the same build process. |
I'm just curious how fast this completes without building rails master.
We could run a subset of integration tests on JRuby—the latest version of Rails and Sinatra, for instance.
There was a problem hiding this comment.
This seems to be as good as it gets (with GH Actions optimization). It seems like most of the extra time for JRuby builds is spent in bundle install. I reduced the number of builds (which had a negligible effect). In the future I might move the JRuby build to a periodic job or something, since it's mainly an integration test (we primarily care about full coverage on MRI).
Adds jruby 9.2.14.0 to gh workflows.
Fixes Fix JRuby GitHub Actions workflow #389
CI/test suite optimization #387 has additional context.
@headius this will not run against rails master currently because it require Ruby >= 2.7.0