[Rough draft for input] Create medium between published and archived #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethan-nelson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following from #788...
Right now, I've created a new permission named
task_contribute(didn't know what I should name it) that controls whether a user can comment, take/lock a task, unlock a task, mark a task done, or invalidate or validate a task.Though this permission is enforced for all those actions in the task model, it for the most part should not even be required since I have modified the task mako template to hide the comment box and action button if a project is closed and the user isn't a PM or admin.
Since the definition of an archived project has changed, I also altered the project due date to turn the project to closed instead of archived.
As it stands, all archived projects will now be defined as
closed(that name still unsure what to call it) so PMs and admins can archive projects (possibly retain this name still) that they want to.I cobbled this together in about an hour so it's far from perfect...and it won't pass CI checks until I clean things up later.