Skip to content

Commit

Permalink
cluster settings issue
Browse files Browse the repository at this point in the history
  • Loading branch information
YenchangChan committed Aug 25, 2024
1 parent db6af9c commit 70f742a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 16 deletions.
2 changes: 1 addition & 1 deletion controller/clickhouse.go
Original file line number Diff line number Diff line change
Expand Up @@ -3014,7 +3014,7 @@ func mergeClickhouseConfig(conf *model.CKManClickHouseConfig, force bool) (bool,
}

// need restart
if cluster.Port != conf.Port || storageChanged || expertChanged || keeperChanged {
if force || cluster.Port != conf.Port || storageChanged || expertChanged || keeperChanged {
restart = true
}

Expand Down
15 changes: 0 additions & 15 deletions service/runner/handle.go
Original file line number Diff line number Diff line change
Expand Up @@ -322,21 +322,6 @@ func CKSettingHandle(task *model.Task) error {
return err
}

// sync table schema when logic cluster exists
deploy.SetNodeStatus(task, model.NodeStatusStore, model.ALL_NODES_DEFAULT)
if d.Conf.LogicCluster != nil {
logics, err := repository.Ps.GetLogicClusterbyName(*d.Conf.LogicCluster)
if err == nil && len(logics) > 0 {
for _, logic := range logics {
if cluster, err := repository.Ps.GetClusterbyName(logic); err == nil {
if clickhouse.SyncLogicTable(cluster, *d.Conf) {
break
}
}
}
}
}

if err := repository.Ps.Begin(); err != nil {
return errors.Wrapf(err, "[%s]", model.NodeStatusStore.EN)
}
Expand Down

0 comments on commit 70f742a

Please sign in to comment.