Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-31411 Make work unit IDs case insensitive #19399

Merged
merged 1 commit into from
Jan 20, 2025
Merged

HPCC-31411 Make work unit IDs case insensitive #19399

merged 1 commit into from
Jan 20, 2025

Conversation

timothyklemm
Copy link
Contributor

@timothyklemm timothyklemm commented Jan 10, 2025 •
edited
Loading

  • Accept either 'w' or 'W' at the start of WUID filter patterns.
  • Improve reliability of ignoring leading and trailing whitespace.
  • Introduce a WUID pattern encapsulation that will grow to include more robust and standardized pattern analysis.

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-31411

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

@timothyklemm timothyklemm requested a review from asselitx January 10, 2025 17:32
asselitx
asselitx approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@asselitx asselitx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you just add that newline it looks good.

common/workunit/workunit.cpp Outdated
pattern.trim();
if (!pattern.isEmpty() && islower(pattern.charAt(0)))
pattern.setCharAt(0, toupper(pattern.charAt(0)));
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you're missing a final newline in this file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look again. I went ahead and squashed because the one change is easy enough to confirm.

@timothyklemm
Copy link
Contributor Author

@ghalliday this should be ready to merge.

@ghalliday ghalliday changed the base branch from master to candidate-9.10.x January 16, 2025 17:02
@ghalliday
Copy link
Member

@timothyklemm this needs rebasing before it is merged.

HPCC-31411 Make work unit IDs case insensitive
3e7801b 
- Accept either 'w' or 'W' at the start of WUID filter patterns.
- Improve reliability of ignoring leading and trailing whitespace.
- Introduce a WUID pattern encapsulation that will grow to include more robust
  and standardized pattern analysis.

Signed-off-by: Tim Klemm<[email protected]>
@timothyklemm
Copy link
Contributor Author

@ghalliday rebase complete

@ghalliday ghalliday merged commit 6725944 into hpcc-systems:candidate-9.10.x Jan 20, 2025
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asselitx asselitx asselitx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timothyklemm @ghalliday @asselitx