Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various coverity-related fixes #19416

Open
wants to merge 7 commits into
base: candidate-9.10.x
Choose a base branch
from
Open

Various coverity-related fixes #19416

wants to merge 7 commits into from

Conversation

richardkchapman
Copy link
Member

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

Compiled

jakesmith and others added 6 commits January 14, 2025 17:20
@jakesmith
Split off 9.10.0
88f1fad 
Signed-off-by: Jake Smith <[email protected]>
@richardkchapman
HPCC-33248 Fix coverity race report 1616786 in setKeyCacheLimit
21796ea 
Unlikely to cause any issues in reality as the function is only called at
startup/between jobs, but no reason not to fix it.

Signed-off-by: Richard Chapman <[email protected]>
@richardkchapman
HPCC-33249 Fix coverity race reports in ldapConnection
686e3aa 
This fixes and/or silences coverity reports 1617206, 1617063, 1616970

Signed-off-by: Richard Chapman <[email protected]>
@richardkchapman
HPCC-33252 Fix Coverity-reported issue in jwtCache.cpp
13a1db3 
It's a bit pointless to support this function as the returned value may be invalid
as soon as the function returns. It appears to be unused, so remove it.

Signed-off-by: Richard Chapman <[email protected]>
@richardkchapman
HPCC-33254 Fix missing atomic related to potential data race in keydi…
7eab1ba 
…ff.cpp

Signed-off-by: Richard Chapman <[email protected]>
@richardkchapman
HPCC-33256 Fix coverity report in jhinplace.cpp
cc674d6 
Signed-off-by: Richard Chapman <[email protected]>
@richardkchapman
HPCC-33231 Coverity scan reported data race
385c0b5 
Add comment to explain why it's a non-issue

Signed-off-by: Richard Chapman <[email protected]>
@ghalliday ghalliday changed the base branch from master to candidate-9.10.x January 16, 2025 16:36
ghalliday
ghalliday approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardkchapman looks good. Please can you squash and rebase onto 9.10.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghalliday ghalliday ghalliday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richardkchapman @ghalliday @jakesmith