-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-32732 Include 24.04 builds for 9.10+ #19418
HPCC-32732 Include 24.04 builds for 9.10+ #19418
Conversation
Signed-off-by: Michael Gardner <[email protected]>
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-32732 Jirabot Action Result: |
@xwang2713 Tested here https://github.com/Michael-Gardner/HPCC-Platform/actions/runs/12794238618/job/35668941837 Final artifacts are here for testing https://github.com/Michael-Gardner/HPCC-Platform/releases/tag/community_HPCC-32732-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@ghalliday ready for merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 question
@@ -87,6 +87,10 @@ jobs: | |||
strategy: | |||
matrix: | |||
include: | |||
- os: ubuntu-24.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have a name? Same for 22.04?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. The 'name' is a way for us to label the builds so we can tell at a glance what special flags are turned on in the github actions' job tab. Anything that doesn't have a special name like LN, k8, or a combination of the two is a standard platform build.
Type of change:
Checklist:
Smoketest:
Testing: