BC-8738 - Remove imports from modules in testing (Part 2) #5436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bischofmax
commented
Jan 16, 2025
apps/server/src/modules/board/controller/media-board/api-test/media-board.api.spec.ts
Show resolved
Hide resolved
bischofmax
commented
Jan 16, 2025
| @@ -0,0 +1,2 @@ | |||
| export * from './group-entity.factory'; | |||
There was a problem hiding this comment.
Wollen wir in diesen Testing-Ordnern überhaupt index Files haben? Wenn daraus von anderen Modulen importiert wird, holen wir in diese Module unnötig viel Code.
bergatco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to move @shared/testing to @testing on same folder level like shared. This should mitigated the problem with imports from modules in testing for the api-test-helpers.
Links to Tickets or other pull requests
JIRA :
Related JIRA :
Related PRs :
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.