BC-8404 - Move tldraw config to issolate it from server config #42
Conversation
| TLDRAW__ASSETS_ALLOWED_MIME_TYPES_LIST: "image/png,image/jpeg,image/gif,image/svg+xml" | ||
| FEATURE_TLDRAW_ENABLED: "true" | ||
| NEST_LOG_LEVEL: "info" | ||
| EXIT_ON_ERROR: "true" |
There was a problem hiding this comment.
Is default true in code
There was a problem hiding this comment.
After all i personally think it's a very bad Idea to exit on error.
Specaly on a multi user and board POD.
Why i think so is that if for one user an error happened all other users with other boards are even face the consequences of the restart.
src/modules/server/server.config.ts
Outdated
| @@ -3,28 +3,28 @@ import { IsArray, IsBoolean, IsNumber, IsString, IsUrl } from 'class-validator'; | |||
|
|
|||
| export class ServerConfig { | |||
There was a problem hiding this comment.
Können wir ServerConfig umbenennen? Als ich das im Code gelesen habe, haben bei mir gleich alle Alarmglocken geläutet, weil ich dachte, wir nutzen hier die ServerConfig vom schulcloud-server.
Mein Vorschlag wäre TldrawServerConfig?
Wenn nicht, ist auch okay! Muss ich nur meinen inneren Monk versuchen das beizubringen.
|
Description
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/browse/BC-8404
BC-8404 - Move tldraw config to issolate it from server config tldraw-client#118
BC-8404 - Move tldraw config to issolate it from server config dof_app_deploy#1039
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Screenshots of UI changes
Approval for review