BC-8403 Code improvements #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ul-cloud/tldraw-server into BC-8403-code-improvments
…ul-cloud/tldraw-server into BC-8403-code-improvments
…ul-cloud/tldraw-server into BC-8403-code-improvments
CeEv
commented
Dec 12, 2024
| import { RedisService } from '../../../infra/redis/redis.service.js'; | ||
| import { StorageService } from '../../../infra/storage/storage.service.js'; | ||
| import { registerYWebsocketServer } from '../../../infra/y-redis/ws.service.js'; | ||
| import { RedisAdapter } from '../../../infra/redis/interfaces/redis-adapter.js'; |
There was a problem hiding this comment.
index.ts files für das y-redis module und redis Module wären Goldwert um die Imports übersichtlicher zu machen und aufzuzeigen was man von dort überhaupt verwenden darf. So ist es beim Review nicht möglich und man muss davon ausgehen das alles nutzbar ist.
There was a problem hiding this comment.
Wird im nächstem Ticket aufgeräumt!!!
CeEv
commented
Dec 12, 2024
CeEv
commented
Dec 12, 2024
CeEv
commented
Dec 12, 2024
…esponse for users without write access or missing room
…rties and update related factories and tests
bergatco
reviewed
Dec 13, 2024
| import { isSmallerRedisId } from './helper.js'; | ||
| import { DocumentStorage } from './storage.js'; | ||
| import { YRedisClient } from './y-redis.client.js'; | ||
|
|
||
| export const running = true; |
| @@ -66,8 +68,7 @@ describe('Websocket Api Test', () => { | |||
| describe('when clients have permission for room', () => { | |||
| describe('when two clients connect to the same doc before any changes', () => { | |||
| const setup = () => { | |||
| const randomString = Math.random().toString(36).substring(7); | |||
| const room = randomString; | |||
| const room = Math.random().toString(36).substring(7); | |||
There was a problem hiding this comment.
Kann der obige Kommentar (evtl. gerade eingeklappt) nicht weg?
/* const waitUntilDocValueMatches = (ydoc: Doc, key: string, value: number): Promise<void> =>
promise.until(0, () => {
const result = ydoc.getMap().get(key);
const isMatch = result === value;
return isMatch;
}); */
Bzw. scheinen hier auch noch mehrere Kommentare zu sein, die eventuell weg könnten?
There was a problem hiding this comment.
Wird im nächstem Ticket aufgeräumt!!!
| import { RedisService } from '../../../infra/redis/redis.service.js'; | ||
| import { StorageService } from '../../../infra/storage/storage.service.js'; | ||
| import { registerYWebsocketServer } from '../../../infra/y-redis/ws.service.js'; | ||
| import { RedisAdapter } from '../../../infra/redis/interfaces/redis-adapter.js'; |
…nd implement OnModuleDestroy for cleanup
bergatco
reviewed
Dec 16, 2024
|
bischofmax
approved these changes
Dec 16, 2024
bergatco
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to Tickets or other pull requests
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Screenshots of UI changes
Approval for review