[#1411] support designated IPV4/IPV6 type configuration for register endpoint #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r register endpoint
liubao68
reviewed
Jan 13, 2025
| @@ -74,6 +74,8 @@ public class DiscoveryBootstrapProperties { | |||
| // enabled: true | |||
| private boolean enableServicePolling = false; | |||
|
|
|||
There was a problem hiding this comment.
It's better to use a boolean configuration to check if prefer ipv4 or ipv6. Or you can use an enum.
liubao68
reviewed
Jan 13, 2025
| @@ -32,7 +32,7 @@ public class DiscoveryBootstrapProperties { | |||
|
|
|||
| private boolean watch = false; | |||
|
|
|||
| private boolean enableZoneAware = false; | |||
| private boolean enabledZoneAware = false; | |||
There was a problem hiding this comment.
Undo the modification
liubao68
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.