Add support for individual model permissions #1631
Open
+501
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- I originally set APP_BASE to '/' instead of '' because setting cookies requires the slash and I wanted to reuse the APP_BASE env var when setting cookies - However, this seems to cause problems with svelte which doesn't allow APP_BASE to end in a slash (even if it's just a single slash): see https://svelte.dev/docs/kit/configuration#paths - Changed the logic so that APP_BASE can be '' if desired and when setting cookies, we just set the path to '/' if APP_BASE is ''
zacps
force-pushed
the
model-permissions-upstream
branch
from
4d58368 to
1f1c799
Compare
|
@nsarrazin This should be ready for review now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for restricting individual models based on group membership.
We only wrote support for Microsoft Entra, as it's the only auth provider we use, but it should be simple to add support for other providers in future.
This was rebased from our fork, and I've done some primitive testing, but I may have introduced bugs accidentally.
Credit for the original work goes to @jonstrutz11.
Fixes #1417