-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for symlinks #865
base: main
Are you sure you want to change the base?
Conversation
I'm happy it looks like small changes and could only get a quick look at the CI. My guess is that it has to do with the |
Thanks again for taking action so promptly on this PR. I initially thought that excluded files required special treatment but then I realized that both arrays are built using the same Admittedly, I haven't tested the changes in a scenario where files are excluded so I would take a closer look at this detail and make the appropriate adjustments. |
The latest commit attempts to fix the issue with files listed in the |
I think there is some work left to do here:
|
Update main branch from original repository
I haven't addressed the two points you mentioned last year. I only needed to update my branch with the latest main branch. I will see if I can work on those two points later this month. |
Concerning #683, the proposed changes are aimed at guaranteeing the subpath in the output directory is returning the correct values even when libraries are symlinked from a local location.
Since a Symfony Finder component returns files in an associative array where keys are the path of files always relative to the current project even when symlinks are followed, those keys can be effectively used to determine the subpath of the files in the output directory. The advantage is that there will not be any difference when the local library is replaced with the production one.
Please consider that, unlike what we discussed in #683, this first approach replaces the logic behind the current implementation. If this works, we could consider letting the two different strategies coexist through the appropriate configuration.