feat: arrow entity handling and damage.

[andrewgazelka]

Arrow Entity handling and damage.

Arrow hitting blocks and damaging entities

Despawn Arrow and clamp velocity properly :)

hand animations 👍

fix bow?

first_collision rewrite. somewhat fixed arrow through floor

[andrewgazelka]

• feat: arrow entity handling and damage. #772 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[andrewgazelka]

So I have a couple thoughts. Mainly, if the ray code doesn't have an issue right now, let's not change it. Or let's try to at least move it to a separate PR if you think it's an optimization and won't break anything. I don't want to have this PR have too many separate changes in it.

I also added benchmarking (#781). So if you're making a change like this, beyond the test passing, we should also see a big change in how long it takes to run the benchmarks, the micro benchmarks. Which will be pretty interesting.

Also, okay, I suppose you can move spatial in, but in the future let's try to make modules separate. We should put some effort to making them separate in the future.

[andrewgazelka]

add a comment why this is true.

[github-actions]

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  22.2 ns ...  25.5 ns ]     +14.81%*
ray_intersection/aabb_size_1                       [  22.4 ns ...  25.1 ns ]     +12.05%*
ray_intersection/aabb_size_10                      [  23.5 ns ...  22.7 ns ]      -3.09%
ray_intersection/ray_distance_1                    [   5.1 ns ...   5.1 ns ]      -0.14%
ray_intersection/ray_distance_5                    [   9.6 ns ...   9.1 ns ]      -4.88%
ray_intersection/ray_distance_20                   [   9.6 ns ...   9.1 ns ]      -5.00%
overlap/no_overlap                                 [  30.4 ns ...  31.3 ns ]      +2.77%
overlap/partial_overlap                            [  30.5 ns ...  31.3 ns ]      +2.49%
overlap/full_containment                           [  23.0 ns ...  23.0 ns ]      -0.01%
point_containment/inside                           [   5.9 ns ...   5.9 ns ]      +0.01%
point_containment/outside                          [   5.3 ns ...   5.3 ns ]      -0.07%
point_containment/boundary                         [   5.8 ns ...   5.8 ns ]      -0.10%

Comparing to d0838c5

[andrewgazelka]

🎯 Bounty Added!

This issue is now tracked by BountyBot. View and manage this bounty at:
http://localhost:3000/github/hyperion-mc/hyperion/issues/772

• 3% weekly decay applies
• Funds are held in escrow
• 14-day review period after completion

Happy coding! 🚀

[github-actions]

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  22.2 ns ...  23.7 ns ]      +7.05%*
ray_intersection/aabb_size_1                       [  22.3 ns ...  23.6 ns ]      +5.59%*
ray_intersection/aabb_size_10                      [  23.1 ns ...  22.5 ns ]      -2.86%
ray_intersection/ray_distance_1                    [   5.1 ns ...   5.1 ns ]      +0.07%
ray_intersection/ray_distance_5                    [   9.6 ns ...   9.4 ns ]      -2.28%
ray_intersection/ray_distance_20                   [   9.6 ns ...   9.4 ns ]      -2.34%
overlap/no_overlap                                 [  30.5 ns ...  31.1 ns ]      +2.24%
overlap/partial_overlap                            [  30.2 ns ...  31.1 ns ]      +2.99%
overlap/full_containment                           [  22.9 ns ...  22.9 ns ]      +0.08%
point_containment/inside                           [   5.9 ns ...   5.9 ns ]      -0.05%
point_containment/outside                          [   5.3 ns ...   5.3 ns ]      -0.13%
point_containment/boundary                         [   5.8 ns ...   5.8 ns ]      +0.30%

Comparing to d0838c5

[github-actions]

Benchmark Results for general

ray_intersection/aabb_size_0.1                     [  22.1 ns ...  23.8 ns ]      +7.46%*
ray_intersection/aabb_size_1                       [  23.3 ns ...  24.8 ns ]      +6.14%*
ray_intersection/aabb_size_10                      [  23.3 ns ...  22.6 ns ]      -3.03%
ray_intersection/ray_distance_1                    [   5.1 ns ...   5.1 ns ]      +0.10%
ray_intersection/ray_distance_5                    [   9.6 ns ...   9.4 ns ]      -2.17%
ray_intersection/ray_distance_20                   [   9.6 ns ...   9.4 ns ]      -2.11%
overlap/no_overlap                                 [  31.2 ns ...  31.2 ns ]      -0.00%
overlap/partial_overlap                            [  31.0 ns ...  31.1 ns ]      +0.06%
overlap/full_containment                           [  23.8 ns ...  23.8 ns ]      +0.00%
point_containment/inside                           [   5.9 ns ...   5.9 ns ]      -0.13%
point_containment/outside                          [   5.3 ns ...   5.3 ns ]      -0.11%
point_containment/boundary                         [   5.8 ns ...   5.8 ns ]      +0.06%

Comparing to d0838c5

[codecov]

Codecov Report

Attention: Patch coverage is 20.82192% with 289 lines in your changes missing coverage. Please review.

Project coverage is 24.61%. Comparing base (d0838c5) to head (bc9a4cb).

Files with missing lines	Patch %	Lines
events/tag/src/module/bow.rs	0.00%	161 Missing ⚠️
crates/hyperion/src/egress/sync_entity_state.rs	24.54%	82 Missing and 1 partial ⚠️
crates/hyperion/src/simulation/blocks/mod.rs	20.00%	19 Missing and 1 partial ⚠️
crates/geometry/src/aabb.rs	69.23%	1 Missing and 7 partials ⚠️
crates/hyperion/src/simulation/handlers.rs	0.00%	8 Missing ⚠️
crates/geometry/src/ray.rs	72.72%	2 Missing and 4 partials ⚠️
crates/hyperion/src/simulation/mod.rs	66.66%	2 Missing ⚠️
events/tag/src/command/raycast.rs	0.00%	1 Missing ⚠️

@@            Coverage Diff             @@
##             main     #772      +/-   ##
==========================================
+ Coverage   23.49%   24.61%   +1.12%     
==========================================
  Files         160      159       -1     
  Lines       15836    15912      +76     
  Branches      374      362      -12     
==========================================
+ Hits         3720     3917     +197     
+ Misses      12018    11894     -124     
- Partials       98      101       +3     

Files with missing lines	Coverage Δ
crates/hyperion/src/lib.rs	84.36% <ø> (ø)
crates/hyperion/src/simulation/animation.rs	0.00% <ø> (ø)
crates/hyperion/src/simulation/event.rs	0.00% <ø> (ø)
crates/hyperion/src/spatial/mod.rs	83.18% <100.00%> (ø)
crates/hyperion/src/storage/event/queue/mod.rs	90.62% <100.00%> (+0.62%)	⬆️
events/tag/src/lib.rs	0.00% <ø> (ø)
events/tag/src/command/raycast.rs	0.00% <0.00%> (ø)
crates/hyperion/src/simulation/mod.rs	35.06% <66.66%> (+0.06%)	⬆️
crates/geometry/src/ray.rs	77.08% <72.72%> (+21.26%)	⬆️
crates/geometry/src/aabb.rs	67.41% <69.23%> (+0.10%)	⬆️
... and 4 more

... and 7 files with indirect coverage changes