ci(custom-checks): fix dependencies being inconsistent phase 5 #3719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruzell22
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
|
Hello @ruzell22 , please fix the conflicts first |
ruzell22
force-pushed
the
issue3688fix
branch
2 times, most recently
from
2d3df74 to
a0b480e
Compare
Primary Changes --------------- 1. Fixed dependencies on targeted packages: packages/cactus-plugin-keychain-azure-kv packages/cactus-plugin-keychain-google-sm packages/cactus-plugin-keychain-memory packages/cactus-plugin-keychain-memory-wasm packages/cactus-plugin-keychain-vault Fixes: hyperledger-cacti#3688 Signed-off-by: ruzell22 <[email protected]>
outSH
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit to be reviewed
ci(custom-checks): fix dependencies being inconsistent phase 5
Fixes: #3688
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.