Nonroot User in Docker Image #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hfuss <[email protected]>
Signed-off-by: hfuss <[email protected]>
nguyer
approved these changes
Oct 12, 2023
nguyer
reviewed
Oct 25, 2023
| COPY --from=solidity-build --chown=1001:0 /home/node/contracts /home/node/package*.json ./ | ||
| RUN npm install --production | ||
| WORKDIR /app/contracts | ||
| COPY --from=solidity-build --chown=1001:0 /home/node/artifacts/contracts/TokenFactory.sol/TokenFactory.json ./ |
There was a problem hiding this comment.
I didn't realize when I reviewed this originally that this moves the location of the compiled contracts in the built filesystem. The FireFly CLI will also need a code change to be able to find these contracts in the new location, or we need to move them back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aiming to support arbitrary user IDs, or non-root numeric users, for running in clouds like OpenShift.