-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically generate and push release info to R2 bucket on every release #526
Automatically generate and push release info to R2 bucket on every release #526
Conversation
2a74550
to
02d33b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it makes it easier, we could merge the PR #545 into this branch and close it so that we dont need another pr to remove the old versioninfo code from this as well. also this would mean theres now 2 places to maintain versioninfo.ts? i think we should be able to reference the existing one?
i think the contents of the two would have little to no overlap right? the new one here would only have the github API related code, while in the other only the releases JSON related code. |
Ah I see yea you’re right |
Description
/tools/release-info
) to generatemodus-all.json
,modus-preview.json
,modus-preview-all.json
, andmodus-preview.json
,/cli/src/util/versioninfo.ts
, most of which should be removed in remove all github api call references, add prerelease support to CLI #545release-info
, which is a standalone workflow that can be invoked both manually (workflow_dispatch
) and from another workflow (workflow_call
), which in our case isrelease-cli
,release-runtime
,release-sdk-as
, andrelease-sdk-go
,Checklist
CHANGELOG.md
file describing and linking to this PR