Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically generate and push release info to R2 bucket on every release #526

Conversation

kevinmingtarja
Copy link
Member

@kevinmingtarja kevinmingtarja commented Oct 30, 2024

Description

  • Made a new script (/tools/release-info) to generate modus-all.json, modus-preview.json, modus-preview-all.json, and modus-preview.json,
  • Copied most of the code from /cli/src/util/versioninfo.ts, most of which should be removed in remove all github api call references, add prerelease support to CLI #545
  • Created release-info, which is a standalone workflow that can be invoked both manually (workflow_dispatch) and from another workflow (workflow_call), which in our case is release-cli, release-runtime, release-sdk-as, and release-sdk-go,
  • This workflow simply compiles and runs the script, and pushes the four JSON files to our releases R2 bucket

Checklist

  • Code compiles correctly and linting passes locally
  • Entry added to the CHANGELOG.md file describing and linking to this PR

@kevinmingtarja kevinmingtarja marked this pull request as ready for review November 3, 2024 06:42
@kevinmingtarja kevinmingtarja requested a review from a team as a code owner November 3, 2024 06:42
@kevinmingtarja kevinmingtarja enabled auto-merge (squash) November 3, 2024 06:42
@kevinmingtarja kevinmingtarja force-pushed the kevinm/hyp-2523-automatically-generate-and-push-release-info-to-r2-bucket-on branch from 2a74550 to 02d33b1 Compare November 3, 2024 07:01
Copy link
Member

@jairad26 jairad26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it makes it easier, we could merge the PR #545 into this branch and close it so that we dont need another pr to remove the old versioninfo code from this as well. also this would mean theres now 2 places to maintain versioninfo.ts? i think we should be able to reference the existing one?

@kevinmingtarja
Copy link
Member Author

if it makes it easier, we could merge the PR #545 into this branch and close it so that we dont need another pr to remove the old versioninfo code from this as well. also this would mean theres now 2 places to maintain versioninfo.ts? i think we should be able to reference the existing one?

i think the contents of the two would have little to no overlap right? the new one here would only have the github API related code, while in the other only the releases JSON related code.

@jairad26
Copy link
Member

jairad26 commented Nov 4, 2024

i think the contents of the two would have little to no overlap right? the new one here would only have the github API related code, while in the other only the releases JSON related code.

Ah I see yea you’re right

tools/release-info/index.ts Outdated Show resolved Hide resolved
tools/release-info/index.ts Outdated Show resolved Hide resolved
tools/release-info/package.json Show resolved Hide resolved
@kevinmingtarja kevinmingtarja merged commit f8657fb into main Nov 4, 2024
6 checks passed
@kevinmingtarja kevinmingtarja deleted the kevinm/hyp-2523-automatically-generate-and-push-release-info-to-r2-bucket-on branch November 4, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants