fix: Don't empty previous contents of build dir #568
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the AssemblyScript SDK, the build script wipes the contents of the
build
directory clean before writing new files. While this may sound good, there are two side effects that appear when usingmodus dev
:.wasm
file is removed, then re-added. So the runtime will see it as unregister/register, rather than just re-register..env
and.env.*
) are removed any time a code change is made.The Go SDK doesn't have this issue, because it doesn't wipe the
build
directory. It just overwrites as needed.Removing the file deletion code from the build script will fix the issues and align the two SDKs to have the same behavior.
Checklist
CHANGELOG.md
file describing and linking to this PR