Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use user provided name for package.json and go.mod #595

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

octref
Copy link
Member

@octref octref commented Nov 19, 2024

Description

  • Use user provided name for package.json and go.mod
  • Remove package-lock.json from the template, as it'll be recreated during npm install for new projects

Checklist

  • Code compiles correctly and linting passes locally
  • For all code changes, an entry added to the CHANGELOG.md file describing and linking to this PR
  • Tests added for new functionality, or regression tests for bug fixes added as applicable
  • For public APIs, new features, etc., PR on docs repo staged and linked here

@octref octref requested a review from a team as a code owner November 19, 2024 21:35
Copy link
Member

@mattjohnsonpint mattjohnsonpint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, let's just use go mod edit -module <name> in the cli. We're already doing the equivalent for NPM. Thanks.

@octref octref enabled auto-merge (squash) November 19, 2024 23:32
@octref octref merged commit 7b9dacc into main Nov 20, 2024
34 checks passed
@octref octref deleted the pine/modus-new-names branch November 20, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants