.

hypermodeinc · Jan 3, 2025 · 0cbe924 · 0cbe924
1 parent b483510
commit 0cbe924
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 18 deletions.
diff --git a/api.go b/api.go
@@ -84,19 +84,14 @@ func Upsert[T any](db *DB, object T, ns ...uint64) (uint64, T, bool, error) {
 		return 0, object, false, err
 	}
 
-	if gid != 0 {
-		gid, _, err = getByGidWithObject[T](ctx, n, gid, object)
-		if err != nil && err != utils.ErrNoObjFound {
-			return 0, object, false, err
-		}
-		wasFound = err == nil
-	} else if cf != nil {
-		gid, _, err = getByConstrainedFieldWithObject[T](ctx, n, *cf, object)
+	if gid != 0 || cf != nil {
+		gid, err = getExistingObject[T](ctx, n, gid, cf, object)
 		if err != nil && err != utils.ErrNoObjFound {
 			return 0, object, false, err
 		}
 		wasFound = err == nil
 	}
+
 	if gid == 0 {
 		gid, err = db.z.nextUID()
 		if err != nil {

diff --git a/mutation_create.go → api_mutation_gen.go b/mutation_create.go → api_mutation_gen.go
diff --git a/mutation_helpers.go b/mutation_helpers.go
@@ -54,16 +54,8 @@ func getUidOrMutate[T any](ctx context.Context, db *DB, n *Namespace, object T)
 	if err != nil {
 		return 0, err
 	}
-	if gid != 0 {
-		gid, _, err = getByGidWithObject[T](ctx, n, gid, object)
-		if err != nil && err != utils.ErrNoObjFound {
-			return 0, err
-		}
-		if err == nil {
-			return gid, nil
-		}
-	} else if cf != nil {
-		gid, _, err = getByConstrainedFieldWithObject[T](ctx, n, *cf, object)
+	if gid != 0 || cf != nil {
+		gid, err = getExistingObject(ctx, n, gid, cf, object)
 		if err != nil && err != utils.ErrNoObjFound {
 			return 0, err
 		}

diff --git a/query_execution.go b/query_execution.go
@@ -184,3 +184,16 @@ func executeQuery[T any](ctx context.Context, n *Namespace, queryParams QueryPar
 
 	return gids, objs, nil
 }
+
+func getExistingObject[T any](ctx context.Context, n *Namespace, gid uint64, cf *ConstrainedField, object T) (uint64, error) {
+	var err error
+	if gid != 0 {
+		gid, _, err = getByGidWithObject[T](ctx, n, gid, object)
+	} else if cf != nil {
+		gid, _, err = getByConstrainedFieldWithObject[T](ctx, n, *cf, object)
+	}
+	if err != nil {
+		return 0, err
+	}
+	return gid, nil
+}