Hyprland-systemd.desktop fix #8351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should still have a way to differentiate the (non)systemd sessions. We could name this Hyprland-systemd. |
|
I thought about it, but I'm not sure how uwsm handles those entries. The fix is entirely based on feedback from the commentary I linked. UPD: I think it makes sense to hold the PR until @Vladimir-csp response. |
|
JFYI I responded in #8318 |
|
Since, we decided to leave pr in its current state, @fufexan ping for a review. |
fufexan
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Rename
DesktopNames=Hyprland (systemd session)toDesktopNames=Hyprlandfor compatibility with uwsm and, possibly, other display managers.#8318 (comment)
Is there anything you want to mention?
No
Is it ready for merging, or does it need work?
Yes