default/config: move shadow options to decoration:shadow #8360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this gonna break existing configs? |
|
No, It just fixes the default config. After d1638a0, it gives errors because shadow options have now moved to |
|
it totally breaks existing configs that auto-populate hyprland.conf, such as stylix. |
|
that is their problem, not ours, no? |
Closed
|
indeed it is, but it does break existing things without issuing a warning of the change first and supporting both models during the transition. For Nix, this seems to be a worthwhile model, if you detect the old model in Nix, convert it to the new model and issue a warning for a version or two. I see this in most things supporting nixpkgs. |
|
supporting both would be a PITA. You can always query version with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it ready for merging, or does it need work?
Yes