fix(Observe): missing traces in Mlflow #148
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Milan Gallas <[email protected]>
GALLLASMILAN
force-pushed
the
fix-missing-traces-in-observe
branch
from
904e842 to
416948c
Compare
jezekra1
reviewed
Jan 7, 2025
| @@ -144,6 +145,7 @@ export async function executeRun(run: LoadedRun) { | |||
| ); | |||
|
|
|||
| await agentRun; | |||
| if (isOpenTelemetryEnabled) await batchSpanProcessor.forceFlush(); | |||
There was a problem hiding this comment.
Is this necessary? I got the impression that opentelemetry should quietly work outside of your code and flush regularly on its own
jezekra1
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to call the
forcePushmethod on theBatchSpanProcessorfor each trace. Otherwise, this default processor skips some traces and doesn't send them to the OTLP server.I added a new
isOpenTelemetryEnabledvariable, that allows the telemetry only for production environment:Closes: i-am-bee/bee-observe#24